Skip to content

Conversation

@d-gubert
Copy link
Member

@d-gubert d-gubert commented May 26, 2025

Proposed changes (including videos or screenshots)

Fixes the logs endpoint to include all necessary fields in the query.

Issue(s)

Steps to test or reproduce

Further comments

#35416

CONN-667

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented May 26, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented May 26, 2025

⚠️ No Changeset found

Latest commit: e7a618b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@d-gubert d-gubert added this to the 7.7.0 milestone May 26, 2025
@d-gubert d-gubert force-pushed the regression/app-logs-endpoint-query branch from 5dd2dac to 5a0402d Compare May 26, 2025 21:02
@github-actions
Copy link
Contributor

github-actions bot commented May 26, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36083/

Built to branch gh-pages at 2025-05-27 16:42 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented May 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.75%. Comparing base (e7b88b6) to head (e7a618b).
Report is 3 commits behind head on release-7.7.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-7.7.0   #36083      +/-   ##
=================================================
+ Coverage          64.21%   64.75%   +0.53%     
=================================================
  Files               3018     3110      +92     
  Lines              91840    93200    +1360     
  Branches           17437    17740     +303     
=================================================
+ Hits               58979    60354    +1375     
+ Misses             30173    30058     -115     
- Partials            2688     2788     +100     
Flag Coverage Δ
e2e 58.43% <ø> (+1.75%) ⬆️
unit 71.51% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@d-gubert d-gubert marked this pull request as ready for review May 27, 2025 12:24
@d-gubert d-gubert force-pushed the regression/app-logs-endpoint-query branch from 5a0402d to b6abf72 Compare May 27, 2025 12:24
@d-gubert d-gubert added the stat: QA assured Means it has been tested and approved by a company insider label May 27, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 27, 2025
@ggazzo ggazzo merged commit 7e05c8f into release-7.7.0 May 27, 2025
43 checks passed
@ggazzo ggazzo deleted the regression/app-logs-endpoint-query branch May 27, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants