Skip to content

Conversation

@MartinSchoeler
Copy link
Member

@MartinSchoeler MartinSchoeler commented May 26, 2025

Proposed changes (including videos or screenshots)

Introduced here: #35218

Adds a missing option to access the Security Logs page on the Enhanced Navbar feature preview

Issue(s)

CORE-1167

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented May 26, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented May 26, 2025

🦋 Changeset detected

Latest commit: 9a9c13f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 39 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/http-router Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/instance-status Patch
@rocket.chat/omni-core Patch
@rocket.chat/omni-core-ee Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented May 26, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36080/

Built to branch gh-pages at 2025-08-04 13:44 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented May 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.45%. Comparing base (2f162a0) to head (9a9c13f).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36080      +/-   ##
===========================================
- Coverage    65.68%   65.45%   -0.24%     
===========================================
  Files         3195     3116      -79     
  Lines       106739   105443    -1296     
  Branches     20317    20046     -271     
===========================================
- Hits         70111    69017    -1094     
+ Misses       33984    33848     -136     
+ Partials      2644     2578      -66     
Flag Coverage Δ
e2e 55.80% <80.00%> (-1.18%) ⬇️
unit 71.30% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MartinSchoeler MartinSchoeler marked this pull request as ready for review July 31, 2025 20:26
@MartinSchoeler MartinSchoeler requested a review from a team as a code owner July 31, 2025 20:26
@dougfabris dougfabris added this to the 7.10.0 milestone Aug 1, 2025
@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Aug 2, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 2, 2025
@kodiakhq kodiakhq bot merged commit fbf6c08 into develop Aug 4, 2025
49 checks passed
@kodiakhq kodiakhq bot deleted the fix/security-logs-navbarv2 branch August 4, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants