-
Notifications
You must be signed in to change notification settings - Fork 13.1k
fix: prometheus' REST API metrics #36070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: fceb082 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #36070 +/- ##
===========================================
+ Coverage 64.94% 64.95% +0.01%
===========================================
Files 3110 3110
Lines 93668 93681 +13
Branches 17793 17798 +5
===========================================
+ Hits 60829 60847 +18
+ Misses 30056 30051 -5
Partials 2783 2783
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
631bf4d to
fceb082
Compare
|
/backport 7.6.3 |
|
Pull request #36134 added to Project: "undefined" |
|
/backport 7.5.2 |
|
Sorry, I couldn't do that backport because of conflicts. Could you please solve them? you can do so by running the following commands: after that just run |
|
/backport 7.5.2 |
|
Pull request #36136 added to Project: "Patch 7.5.2" |
https://rocketchat.atlassian.net/browse/ARCH-1620
Proposed changes (including videos or screenshots)
The metrics will be sent like this:
Before the fix they were not being grouped as shown below, creating multiple entries for the same route:
Issue(s)
Introduced by #34999
Steps to test or reproduce
Further comments