Skip to content

Conversation

@KevLehman
Copy link
Member

@KevLehman KevLehman commented May 23, 2025

Proposed changes (including videos or screenshots)

  • Added support in hono router to x-www-form-urlencoded content type (twilio sends payload in this format)
  • Updated tests to use this content type (since they were using JSON, they didn't catch the problem earlier)

Issue(s)

https://rocketchat.atlassian.net/browse/CTZ-176

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented May 23, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented May 23, 2025

🦋 Changeset detected

Latest commit: a815cf0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36068/

Built to branch gh-pages at 2025-05-23 15:51 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented May 23, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 64.78%. Comparing base (9be51ef) to head (a815cf0).
Report is 1 commits behind head on release-7.7.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-7.7.0   #36068      +/-   ##
=================================================
+ Coverage          64.75%   64.78%   +0.03%     
=================================================
  Files               3110     3110              
  Lines              93180    93183       +3     
  Branches           17748    17757       +9     
=================================================
+ Hits               60338    60372      +34     
+ Misses             30054    30029      -25     
+ Partials            2788     2782       -6     
Flag Coverage Δ
unit 71.58% <33.33%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KevLehman KevLehman added this to the 7.7.0 milestone May 23, 2025
@KevLehman KevLehman marked this pull request as ready for review May 23, 2025 16:41
@KevLehman KevLehman requested a review from a team as a code owner May 23, 2025 16:41
@KevLehman KevLehman added the stat: QA assured Means it has been tested and approved by a company insider label May 23, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 23, 2025
@kodiakhq kodiakhq bot merged commit 5f0b71e into release-7.7.0 May 23, 2025
15 of 16 checks passed
@kodiakhq kodiakhq bot deleted the fix/urlencoded branch May 23, 2025 16:49
@sampaiodiego
Copy link
Member

/patch

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented May 28, 2025

Pull request #36101 added to Project: "undefined"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants