Skip to content

Conversation

@MartinSchoeler
Copy link
Member

@MartinSchoeler MartinSchoeler commented May 23, 2025

Proposed changes (including videos or screenshots)

Adds a pagination component to the App Logs list. Allowing the user to see all the logs, instead of only the latest ones

Screenshot 2025-05-23 at 10 55 04

Issue(s)

ALT-4

Further comments

I have not added tests in this PR for 2 reasons:

  • We cannot do e2e tests on the marketplace as of it now, due it relying on external services to be up
  • I don't think we have anything worth testing using unit tests in this PR, as I am simply adding an existing component to the page

@MartinSchoeler MartinSchoeler added this to the 7.8.0 milestone May 23, 2025
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented May 23, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented May 23, 2025

🦋 Changeset detected

Latest commit: a8c09ad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented May 23, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36067/

Built to branch gh-pages at 2025-05-30 13:57 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented May 23, 2025

Codecov Report

Attention: Patch coverage is 11.11111% with 40 lines in your changes missing coverage. Please review.

Project coverage is 64.95%. Comparing base (b4090e3) to head (a8c09ad).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36067      +/-   ##
===========================================
- Coverage    64.96%   64.95%   -0.02%     
===========================================
  Files         3113     3113              
  Lines        93725    93755      +30     
  Branches     17804    17804              
===========================================
+ Hits         60889    60899      +10     
- Misses       30052    30075      +23     
+ Partials      2784     2781       -3     
Flag Coverage Δ
e2e 58.42% <12.50%> (-0.03%) ⬇️
unit 71.64% <11.11%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MartinSchoeler MartinSchoeler marked this pull request as ready for review May 23, 2025 17:23
@MartinSchoeler MartinSchoeler requested a review from a team as a code owner May 23, 2025 17:23
Co-authored-by: Aleksander Nicacio da Silva <aleksander.silva@rocket.chat>
@aleksandernsilva aleksandernsilva added the stat: QA assured Means it has been tested and approved by a company insider label May 26, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 26, 2025
@kodiakhq kodiakhq bot merged commit 63d0032 into develop May 30, 2025
49 checks passed
@kodiakhq kodiakhq bot deleted the feat/apps-logs-pagination branch May 30, 2025 22:31
This was referenced Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants