Skip to content

Conversation

@tiagoevanp
Copy link
Contributor

@tiagoevanp tiagoevanp commented May 22, 2025

Proposed changes (including videos or screenshots)

Removes the Change to Default language button from the login page

image

Issue(s)

Steps to test or reproduce

Further comments

CORE-1091

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented May 22, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented May 22, 2025

🦋 Changeset detected

Latest commit: 9ff7af1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tiagoevanp tiagoevanp marked this pull request as ready for review May 22, 2025 18:37
@tiagoevanp tiagoevanp requested a review from a team as a code owner May 22, 2025 18:37
@github-actions
Copy link
Contributor

github-actions bot commented May 22, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36062/

Built to branch gh-pages at 2025-05-27 04:24 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented May 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.95%. Comparing base (93a3348) to head (9ff7af1).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #36062   +/-   ##
========================================
  Coverage    64.95%   64.95%           
========================================
  Files         3112     3112           
  Lines        93727    93729    +2     
  Branches     17803    17821   +18     
========================================
+ Hits         60877    60882    +5     
+ Misses       30063    30061    -2     
+ Partials      2787     2786    -1     
Flag Coverage Δ
e2e 58.42% <ø> (+0.01%) ⬆️
unit 71.65% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aleksandernsilva aleksandernsilva added this to the 7.8.0 milestone May 22, 2025
@aleksandernsilva aleksandernsilva added the stat: QA assured Means it has been tested and approved by a company insider label May 22, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 22, 2025
@aleksandernsilva aleksandernsilva removed stat: ready to merge PR tested and approved waiting for merge stat: QA assured Means it has been tested and approved by a company insider labels May 22, 2025
Co-authored-by: Aleksander Nicacio da Silva <aleksander.silva@rocket.chat>
@aleksandernsilva aleksandernsilva added the stat: QA assured Means it has been tested and approved by a company insider label May 26, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 26, 2025
@kodiakhq kodiakhq bot merged commit 8de5b66 into develop May 27, 2025
49 checks passed
@kodiakhq kodiakhq bot deleted the fix/change-default-button branch May 27, 2025 05:12
This was referenced Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants