Skip to content

Conversation

@abhinavkrin
Copy link
Member

@abhinavkrin abhinavkrin commented May 22, 2025

Proposed changes (including videos or screenshots)

This PR fixes an issue which made the validation to not work for incoming webhooks in public rooms.

Issue(s)

Steps to test or reproduce

  1. Create an incoming webhook with a public room.
  2. Call the webhook endpoint with the appropriate message payload. The webhook url last part should be modified to simulate invalid token.
  3. Check that the message is not sent to the room

Further comments

CORE-1161

@abhinavkrin abhinavkrin requested review from a team as code owners May 22, 2025 16:42
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented May 22, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented May 22, 2025

⚠️ No Changeset found

Latest commit: 932efc6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Signed-off-by: Abhinav Kumar <[email protected]>
@abhinavkrin abhinavkrin added this to the 7.7.0 milestone May 22, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 22, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36059/

Built to branch gh-pages at 2025-05-23 13:39 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented May 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.76%. Comparing base (f26a496) to head (932efc6).
Report is 5 commits behind head on release-7.7.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-7.7.0   #36059      +/-   ##
=================================================
+ Coverage          64.74%   64.76%   +0.01%     
=================================================
  Files               3110     3110              
  Lines              93179    93180       +1     
  Branches           17751    17766      +15     
=================================================
+ Hits               60332    60350      +18     
+ Misses             30059    30047      -12     
+ Partials            2788     2783       -5     
Flag Coverage Δ
e2e 58.41% <ø> (+<0.01%) ⬆️
unit 71.55% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Abhinav Kumar <[email protected]>
Copy link
Member

@julio-rocketchat julio-rocketchat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julio-rocketchat julio-rocketchat added the stat: QA assured Means it has been tested and approved by a company insider label May 26, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 26, 2025
@kodiakhq kodiakhq bot merged commit a8a7bc2 into release-7.7.0 May 26, 2025
51 checks passed
@kodiakhq kodiakhq bot deleted the regression/broken-incoming-webhook-validation branch May 26, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants