-
Notifications
You must be signed in to change notification settings - Fork 13.1k
regression: broken incoming webhook validation #36059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regression: broken incoming webhook validation #36059
Conversation
Signed-off-by: Abhinav Kumar <[email protected]>
|
Looks like this PR is ready to merge! 🎉 |
|
Signed-off-by: Abhinav Kumar <[email protected]>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.7.0 #36059 +/- ##
=================================================
+ Coverage 64.74% 64.76% +0.01%
=================================================
Files 3110 3110
Lines 93179 93180 +1
Branches 17751 17766 +15
=================================================
+ Hits 60332 60350 +18
+ Misses 30059 30047 -12
+ Partials 2788 2783 -5
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Signed-off-by: Abhinav Kumar <[email protected]>
julio-rocketchat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed changes (including videos or screenshots)
This PR fixes an issue which made the validation to not work for incoming webhooks in public rooms.
Issue(s)
Steps to test or reproduce
Further comments
CORE-1161