feat: select algorithm to use for signing SAML requests and responses #36037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 6667c47 The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
pierre-lehnen-rc
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Contributor
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #36037 +/- ##
===========================================
+ Coverage 64.52% 64.54% +0.01%
===========================================
Files 3128 3129 +1
Lines 98325 98332 +7
Branches 18648 18653 +5
===========================================
+ Hits 63448 63466 +18
+ Misses 32055 32045 -10
+ Partials 2822 2821 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
sampaiodiego
requested changes
May 23, 2025
Member
|
@pierre-lehnen-rc updating the branch to get the commit that fixes the flaky test |
MarcosSpessatto
suggested changes
Jun 2, 2025
Contributor
MarcosSpessatto
left a comment
MarcosSpessatto
left a comment
There was a problem hiding this comment.
Please add a description to the PR.
gabriellsh
approved these changes
Jun 5, 2025
MarcosSpessatto
approved these changes
Jun 6, 2025
sampaiodiego
approved these changes
Jun 10, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Previously our SAML implementation could only sign requests using the SHA1 algorithm. This PR adds a new setting to choose between SHA1, SHA256, SHA384 and SHA512.
This setting only affects the signing of documents sent from Rocket.Chat to the IdP. It doesn't affect encryption nor the signatures of documents received from the IdP.
Issue(s)
CORE-1148
Steps to test or reproduce
Further comments