fix: Support file filtering across all room types endpoints #36035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like this PR is ready to merge! 🎉 |
Contributor
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #36035 +/- ##
===========================================
- Coverage 64.53% 64.45% -0.08%
===========================================
Files 3128 3278 +150
Lines 98325 101495 +3170
Branches 18650 18940 +290
===========================================
+ Hits 63455 65420 +1965
- Misses 32048 33113 +1065
- Partials 2822 2962 +140
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
🦋 Changeset detectedLatest commit: 35ae6fd The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
abhinavkrin
requested changes
May 30, 2025
abhinavkrin
approved these changes
Jun 2, 2025
MarcosSpessatto
approved these changes
Jun 6, 2025
scuciatto
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
dionisio-bot
bot
removed
the
stat: ready to merge
gabriellsh
added
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
This was referenced Jun 20, 2025
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Currently only the endpoint
channels.filessupports file filtering by passing eithernameortypeGroup. Previously this behaviour was supported with thequeryparameter which is currently deprecated.In this PR #33564,
nameandtypeGroupwere added as query parameters for thechannels.filesendpoint, and the FE logic changed to filter by these parameters. The issue is that other types of rooms, such as private channels and DMs, have separate endpoints, which were not changed to support the new query parameters. This makes the filtering in the files contextual bar unusable for any room type that is not a public channel.This PR introduces the support on the aforementioned endpoints, and also implements tests for the filtering to ensure the behaviour is consistent.
Issue(s)
SUP-799
Steps to test or reproduce
Further comments