Skip to content

Conversation

@aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented May 19, 2025

Proposed changes (including videos or screenshots)

This PR fixes the property withCheckbox not working on the AutoCompleteDepartmentMultiple component. A checkbox should be rendered for each option when withCheckbox is true. This was not happening due to a missing return.

Issue(s)

CTZ-157

Steps to test or reproduce

Can be found in:

  • Business Hours page
  • Create/edit tags page
  • Create/edit unit page
  • Create/edit department page

Further comments

Introduced here #35282

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented May 19, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented May 19, 2025

🦋 Changeset detected

Latest commit: 80afb82

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36029/

Built to branch gh-pages at 2025-05-21 17:30 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented May 19, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.93%. Comparing base (a70075e) to head (80afb82).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36029      +/-   ##
===========================================
+ Coverage    64.91%   64.93%   +0.01%     
===========================================
  Files         3110     3110              
  Lines        93605    93672      +67     
  Branches     17788    17805      +17     
===========================================
+ Hits         60763    60823      +60     
- Misses       30054    30063       +9     
+ Partials      2788     2786       -2     
Flag Coverage Δ
e2e 58.38% <40.00%> (-0.03%) ⬇️
unit 71.61% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aleksandernsilva aleksandernsilva force-pushed the fix/department-with-checkbox branch from 8a7da55 to 490afda Compare May 20, 2025 16:38
@aleksandernsilva aleksandernsilva marked this pull request as ready for review May 21, 2025 16:59
@aleksandernsilva aleksandernsilva requested a review from a team as a code owner May 21, 2025 16:59
@aleksandernsilva aleksandernsilva added this to the 7.8.0 milestone May 21, 2025
@aleksandernsilva aleksandernsilva requested a review from a team as a code owner May 21, 2025 17:25
@aleksandernsilva aleksandernsilva force-pushed the fix/department-with-checkbox branch from 0d666c9 to fe56d6a Compare May 21, 2025 17:48
MartinSchoeler
MartinSchoeler previously approved these changes May 21, 2025
@aleksandernsilva aleksandernsilva added the stat: QA assured Means it has been tested and approved by a company insider label May 22, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 22, 2025
@kodiakhq kodiakhq bot merged commit 94dcf9e into develop May 22, 2025
49 checks passed
@kodiakhq kodiakhq bot deleted the fix/department-with-checkbox branch May 22, 2025 14:22
This was referenced Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants