-
Notifications
You must be signed in to change notification settings - Fork 13k
fix: AutoCompleteDepartmentMultiple withCheckbox property not working
#36029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 80afb82 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #36029 +/- ##
===========================================
+ Coverage 64.91% 64.93% +0.01%
===========================================
Files 3110 3110
Lines 93605 93672 +67
Branches 17788 17805 +17
===========================================
+ Hits 60763 60823 +60
- Misses 30054 30063 +9
+ Partials 2788 2786 -2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
8a7da55 to
490afda
Compare
0d666c9 to
fe56d6a
Compare
Proposed changes (including videos or screenshots)
This PR fixes the property
withCheckboxnot working on theAutoCompleteDepartmentMultiplecomponent. A checkbox should be rendered for each option whenwithCheckboxistrue. This was not happening due to a missingreturn.Issue(s)
CTZ-157
Steps to test or reproduce
Can be found in:
Further comments
Introduced here #35282