Skip to content

Conversation

@juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented May 19, 2025

ARCH-1611

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Configure iframe auth and ensure login works

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented May 19, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented May 19, 2025

⚠️ No Changeset found

Latest commit: a1388c0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36022/

Built to branch gh-pages at 2025-06-03 15:10 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented May 19, 2025

Codecov Report

Attention: Patch coverage is 41.66667% with 49 lines in your changes missing coverage. Please review.

Project coverage is 64.94%. Comparing base (db04086) to head (a1388c0).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #36022   +/-   ##
========================================
  Coverage    64.94%   64.94%           
========================================
  Files         3112     3111    -1     
  Lines        93753    93767   +14     
  Branches     17810    17808    -2     
========================================
+ Hits         60884    60900   +16     
  Misses       30080    30080           
+ Partials      2789     2787    -2     
Flag Coverage Δ
e2e 58.41% <41.66%> (-0.02%) ⬇️
unit 71.65% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@juliajforesti juliajforesti force-pushed the refactor/iframe-login branch from d7007e4 to 8ff953e Compare May 19, 2025 14:57
@juliajforesti juliajforesti force-pushed the refactor/iframe-login branch 4 times, most recently from 0784acb to 10877e1 Compare May 28, 2025 20:26
@juliajforesti juliajforesti force-pushed the refactor/iframe-login branch from 10877e1 to 78070db Compare May 28, 2025 20:32
@juliajforesti juliajforesti marked this pull request as ready for review May 29, 2025 19:14
@juliajforesti juliajforesti requested a review from a team as a code owner May 29, 2025 19:14
@ggazzo
Copy link
Member

ggazzo commented Jun 3, 2025

@codecov-ai-reviewer test

@juliajforesti juliajforesti added this to the 7.8.0 milestone Jun 3, 2025
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Jun 3, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 3, 2025
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Jun 3, 2025
@ggazzo ggazzo merged commit 38ec24b into develop Jun 3, 2025
69 of 74 checks passed
@ggazzo ggazzo deleted the refactor/iframe-login branch June 3, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants