-
Notifications
You must be signed in to change notification settings - Fork 13k
feat: Add OpenAPI Support to chat.pinMessage API #36020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add OpenAPI Support to chat.pinMessage API #36020
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: b195084 The changes in this PR will be included in the next version bump. This PR includes changesets to release 39 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
While analyzing the API behavior using Wireshark, I observed that invoking the endpoint Here is the relevant data from the Wireshark capture: I'm not sure if the repeated requests and responses are intentional or an issue, but I wanted to bring it to your attention. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #36020 +/- ##
===========================================
- Coverage 65.84% 65.56% -0.29%
===========================================
Files 3186 3106 -80
Lines 106663 105371 -1292
Branches 20311 19998 -313
===========================================
- Hits 70237 69091 -1146
+ Misses 33763 33675 -88
+ Partials 2663 2605 -58
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
06e4be5 to
290c1aa
Compare
…ge interface becouse it create an error in typia
|
|
||
| reactions?: { | ||
| [key: string]: { names?: (string | undefined)[]; usernames: string[]; federationReactionEventIds?: Record<string, string> }; | ||
| [key: string]: { names?: string[]; usernames: string[]; federationReactionEventIds?: Record<string, string> }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While working with Typia to generate schemas for IMessage. I ran into an error with this type undefined. typia doesnt allow undefined inside the interface
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description:
This PR integrates OpenAPI support into the
Rocket.Chat API, migrate ofRocket.Chat APIendpoints to the new OpenAPI pattern. The update includes improved API documentation, enhanced type safety, and response validation using AJV.Key Changes:
Issue Reference:
Relates to #34983, part of the ongoing OpenAPI integration effort.
Testing:
Verified that the API response schemas are correctly documented in Swagger UI.
All tests passed without any breaking changes
Endpoint:
Pin Message
Looking forward to your feedback! 🚀