-
Notifications
You must be signed in to change notification settings - Fork 13k
fix: Contact conflict resolution #36019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: b5acf0b The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #36019 +/- ##
===========================================
- Coverage 64.70% 64.70% -0.01%
===========================================
Files 3107 3108 +1
Lines 93087 93098 +11
Branches 17740 17773 +33
===========================================
+ Hits 60232 60237 +5
Misses 30068 30068
- Partials 2787 2793 +6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
09e49b7 to
04a0ceb
Compare
apps/meteor/app/livechat/server/lib/contacts/resolveContactConflicts.ts
Outdated
Show resolved
Hide resolved
apps/meteor/app/livechat/server/lib/contacts/resolveContactConflicts.ts
Outdated
Show resolved
Hide resolved
apps/meteor/app/livechat/server/lib/contacts/resolveContactConflicts.ts
Outdated
Show resolved
Hide resolved
apps/meteor/app/livechat/server/lib/contacts/resolveContactConflicts.ts
Outdated
Show resolved
Hide resolved
|
/backport 7.5.2 |
|
Sorry, I couldn't do that backport because of conflicts. Could you please solve them? you can do so by running the following commands: after that just run |
|
/backport 7.5.2 |
|
Pull request #36176 added to Project: "Patch 7.5.2" |
Proposed changes (including videos or screenshots)
This PR implements a new endpoint to resolve Livechat Contact's conflicts. The reason for this is to decrease the level of coupling inside the
contacts.updateendpoint, so specific business rules don't overlap each other.Issue(s)
CTZ-154
Steps to test or reproduce
Further comments