-
Notifications
You must be signed in to change notification settings - Fork 13.1k
fix: remove apps-engine dependency on internal package #36007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
b532f21 to
1a78ff0
Compare
🦋 Changeset detectedLatest commit: 63e6248 The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #36007 +/- ##
===========================================
+ Coverage 64.73% 64.75% +0.01%
===========================================
Files 3106 3106
Lines 92877 92879 +2
Branches 17675 17677 +2
===========================================
+ Hits 60127 60142 +15
+ Misses 29964 29954 -10
+ Partials 2786 2783 -3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
204efe3 to
5909429
Compare
5909429 to
f1d06dd
Compare
sampaiodiego
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no changes to yarn.lock? 🤔
Rocket.Chat is likely just installing the version in the monorepo, right? Since there was no change to the dependency on the meteor side, I don't think anything would change. Oh, you were actually talking about the change on the apps-engine dependency itself, not the main meteor package, so yeah, the changes to the apps-engine caused an update on |
|
/patch |
after that just run |
|
/patch |
|
Pull request #36033 added to Project: "Patch 7.6.1" |
Proposed changes (including videos or screenshots)
Apps-engine version 1.51.0 was published referencing an internal package that we don't publish
This PR removes that dependency from the apps-engine and applies it in the meteor app
Issue(s)
Steps to test or reproduce
Further comments
This needs to be released as a patch for version 7.6
SUP-797