Skip to content

Conversation

@d-gubert
Copy link
Member

@d-gubert d-gubert commented May 15, 2025

Proposed changes (including videos or screenshots)

Apps-engine version 1.51.0 was published referencing an internal package that we don't publish

This PR removes that dependency from the apps-engine and applies it in the meteor app

Issue(s)

Steps to test or reproduce

Further comments

This needs to be released as a patch for version 7.6

SUP-797

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented May 15, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@d-gubert d-gubert force-pushed the fix/apps-engine-invalid-dependency branch from b532f21 to 1a78ff0 Compare May 15, 2025 18:18
@changeset-bot
Copy link

changeset-bot bot commented May 15, 2025

🦋 Changeset detected

Latest commit: 63e6248

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@rocket.chat/apps-engine Patch
@rocket.chat/meteor Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/core-typings Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/rest-typings Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented May 15, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36007/

Built to branch gh-pages at 2025-05-19 22:24 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented May 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.75%. Comparing base (aadc795) to head (63e6248).
Report is 5 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36007      +/-   ##
===========================================
+ Coverage    64.73%   64.75%   +0.01%     
===========================================
  Files         3106     3106              
  Lines        92877    92879       +2     
  Branches     17675    17677       +2     
===========================================
+ Hits         60127    60142      +15     
+ Misses       29964    29954      -10     
+ Partials      2786     2783       -3     
Flag Coverage Δ
e2e 58.40% <ø> (+0.02%) ⬆️
unit 71.69% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@d-gubert d-gubert force-pushed the fix/apps-engine-invalid-dependency branch 4 times, most recently from 204efe3 to 5909429 Compare May 18, 2025 18:17
@d-gubert d-gubert marked this pull request as ready for review May 18, 2025 23:33
@d-gubert d-gubert requested a review from a team as a code owner May 18, 2025 23:33
@d-gubert d-gubert force-pushed the fix/apps-engine-invalid-dependency branch from 5909429 to f1d06dd Compare May 19, 2025 11:02
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no changes to yarn.lock? 🤔

@d-gubert d-gubert added this to the 7.7.0 milestone May 19, 2025
@d-gubert
Copy link
Member Author

d-gubert commented May 19, 2025

no changes to yarn.lock? 🤔

Rocket.Chat is likely just installing the version in the monorepo, right? Since there was no change to the dependency on the meteor side, I don't think anything would change.


Oh, you were actually talking about the change on the apps-engine dependency itself, not the main meteor package, so yeah, the changes to the apps-engine caused an update on yarn.lock to remove the dependency on @rocket.chat/tools

@sampaiodiego sampaiodiego added the stat: QA assured Means it has been tested and approved by a company insider label May 19, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 19, 2025
@sampaiodiego sampaiodiego merged commit 8d90708 into develop May 20, 2025
47 of 49 checks passed
@sampaiodiego sampaiodiego deleted the fix/apps-engine-invalid-dependency branch May 20, 2025 05:08
@d-gubert
Copy link
Member Author

/patch

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented May 20, 2025

    Sorry, I couldn't do that backport because of conflicts. Could you please solve them?
    
    you can do so by running the following commands:
git fetch
git checkout backport-7.6.1-36007
git cherry-pick 8d907087746dd75bd640c6d51ae0bbb7f3dc43c0
// solve the conflict
git push

after that just run /patch again

@d-gubert
Copy link
Member Author

/patch

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented May 20, 2025

Pull request #36033 added to Project: "Patch 7.6.1"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants