fix: Add loading state recovery over RoomHistoryManager.getMore
#36006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 477264d The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #36006 +/- ##
===========================================
- Coverage 64.80% 64.70% -0.10%
===========================================
Files 3099 3248 +149
Lines 92157 95319 +3162
Branches 17667 17899 +232
===========================================
+ Hits 59718 61677 +1959
- Misses 29674 30736 +1062
- Partials 2765 2906 +141
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
ggazzo
approved these changes
May 16, 2025
ggazzo
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://rocketchat.atlassian.net/browse/ARCH-1609
Proposed changes (including videos or screenshots)
It handles rejections inside the
RoomHistoryManager.getMoremethod (that usually occur during user logout) to not lock the room in a permanent loading state.Issue(s)
Steps to test or reproduce
Further comments
It's specially connected with flakyness of E2E encryption tests.