-
Notifications
You must be signed in to change notification settings - Fork 13k
chore: new omni-core package #35992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: new omni-core package #35992
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #35992 +/- ##
===========================================
- Coverage 65.81% 65.80% -0.02%
===========================================
Files 3188 3188
Lines 106922 106922
Branches 20397 20390 -7
===========================================
- Hits 70373 70358 -15
- Misses 33872 33888 +16
+ Partials 2677 2676 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
bb81c92 to
4f48ff2
Compare
ce91285 to
5869735
Compare
5869735 to
9f90337
Compare
Proposed changes (including videos or screenshots)
Issue(s)
https://rocketchat.atlassian.net/browse/CTZ-203
Steps to test or reproduce
Further comments
This pull request introduces a new package,
omni-lib, to the Rocket.Chat codebase. The changes include the addition of new ESLint and TypeScript configuration files for both theomni-libandomni-lib-eepackages, ensuring consistent code quality and compilation settings.Key updates in this PR involve refactoring the department creation availability check by importing the functionality from the new
@rocket.chat/omni-libpackage, replacing the previous local implementation. This centralization of functionality is part of a broader refactoring effort.Additionally, the PR introduces a new TypeScript module in the
omni-lib-eepackage, which exports a functionpatchOmniLib. This function applies patches, specifically modifying theisDepartmentCreationAvailablefunction to allow unlimited department creation if the 'livechat-enterprise' license is active.The server-side patch initialization has been refactored to include the
patchOmniLibinvocation, and an unused import has been removed to streamline the code. These changes aim to enhance the modularity and maintainability of the Rocket.Chat codebase.