Skip to content

Conversation

@sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented May 14, 2025

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/CTZ-203

Steps to test or reproduce

Further comments


This pull request introduces a new package, omni-lib, to the Rocket.Chat codebase. The changes include the addition of new ESLint and TypeScript configuration files for both the omni-lib and omni-lib-ee packages, ensuring consistent code quality and compilation settings.

Key updates in this PR involve refactoring the department creation availability check by importing the functionality from the new @rocket.chat/omni-lib package, replacing the previous local implementation. This centralization of functionality is part of a broader refactoring effort.

Additionally, the PR introduces a new TypeScript module in the omni-lib-ee package, which exports a function patchOmniLib. This function applies patches, specifically modifying the isDepartmentCreationAvailable function to allow unlimited department creation if the 'livechat-enterprise' license is active.

The server-side patch initialization has been refactored to include the patchOmniLib invocation, and an unused import has been removed to streamline the code. These changes aim to enhance the modularity and maintainability of the Rocket.Chat codebase.

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented May 14, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.10.0, but it targets 7.9.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@kody-ai
Copy link

kody-ai bot commented May 14, 2025

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Security
Code Style
Kody Rules
Refactoring
Error Handling
Maintainability
Potential Issues
Documentation And Comments
Performance And Optimization
Breaking Changes

Access your configuration settings here.

@changeset-bot
Copy link

changeset-bot bot commented May 14, 2025

⚠️ No Changeset found

Latest commit: 89c55fb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented May 14, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35992/

Built to branch gh-pages at 2025-07-28 20:52 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented May 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.80%. Comparing base (e5a6899) to head (89c55fb).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35992      +/-   ##
===========================================
- Coverage    65.81%   65.80%   -0.02%     
===========================================
  Files         3188     3188              
  Lines       106922   106922              
  Branches     20397    20390       -7     
===========================================
- Hits         70373    70358      -15     
- Misses       33872    33888      +16     
+ Partials      2677     2676       -1     
Flag Coverage Δ
e2e 58.11% <ø> (+0.01%) ⬆️
unit 70.93% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sampaiodiego sampaiodiego force-pushed the new-omni-lib-pkg branch 3 times, most recently from ce91285 to 5869735 Compare July 24, 2025 20:24
@sampaiodiego sampaiodiego changed the title chore: new omni-lib package chore: new omni-core package Jul 28, 2025
@sampaiodiego sampaiodiego marked this pull request as ready for review July 28, 2025 19:52
@sampaiodiego sampaiodiego requested a review from a team as a code owner July 28, 2025 19:52
KevLehman
KevLehman previously approved these changes Jul 28, 2025
@sampaiodiego sampaiodiego added the stat: QA assured Means it has been tested and approved by a company insider label Jul 28, 2025
@sampaiodiego sampaiodiego added this to the 7.10.0 milestone Jul 28, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 28, 2025
@sampaiodiego sampaiodiego removed this from the 7.10.0 milestone Jul 28, 2025
@sampaiodiego sampaiodiego modified the milestones: 7.9.0, 7.10.0 Jul 28, 2025
@kodiakhq kodiakhq bot merged commit 2d243d1 into develop Jul 28, 2025
51 checks passed
@kodiakhq kodiakhq bot deleted the new-omni-lib-pkg branch July 28, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants