-
Notifications
You must be signed in to change notification settings - Fork 13k
fix: Air-gapped warning period ignored during daily checks #35959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 87231a5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35959 +/- ##
===========================================
+ Coverage 64.70% 64.73% +0.02%
===========================================
Files 3247 3248 +1
Lines 95434 95462 +28
Branches 17902 17882 -20
===========================================
+ Hits 61753 61797 +44
+ Misses 30778 30762 -16
Partials 2903 2903
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Co-authored-by: Diego Sampaio <[email protected]>
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
Proposed changes (including videos or screenshots)
We run a cron daily that sends statistics to cloud.rocket.chat that retrieves the token responsible for computing airgapped restrictions. The restriction mechanism is supposed to get the last received token when the statistics collector request fails, but that was not the case.
This PR ensures that if the statistics collector fails, the last token available is used, thus correcting the behaviour.
Issue(s)
CORE-1144
Closes #33989
Steps to test or reproduce
Further comments