fix: message search fails for file descriptions or title containing non-ASCII characters #35946
Conversation
… characters Signed-off-by: Abhinav Kumar <[email protected]>
Signed-off-by: Abhinav Kumar <[email protected]>
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: b21a5d1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
![kody-ai[bot]](https://avatars.githubusercontent.com/in/413034?s=60&v=4){kind=small}
|
Signed-off-by: Abhinav Kumar <[email protected]>
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #35946 +/- ##
========================================
Coverage 64.72% 64.72%
========================================
Files 3248 3248
Lines 95462 95468 +6
Branches 17904 17880 -24
========================================
+ Hits 61786 61794 +8
+ Misses 30775 30766 -9
- Partials 2901 2908 +7
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
scuciatto
added
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Proposed changes (including videos or screenshots)
Fixes an issue where searching messages by attachment description or title failed when they contained non-ASCII characters. The problem was caused by the use of
\w+in the regex, which only matches ASCII characters. The regex has been updated to support Unicode characters, thereby enabling search functionality across multiple languages.🧠 How updated search works
file-desc:andfile-title:can be followed by:file-desc:"multi word text"file-title:Summary$text: { $search: "..." }🧪 Examples
file-desc:отчетfile-title:"project plan"file-desc:"budget 💰" file-title:report summaryIssue(s)
Steps to test or reproduce
file-desc:followed by Cyrillic characters in the search.Further comments
SUP-768
This pull request addresses an issue in the Rocket.Chat repository where message searches fail when file descriptions or titles contain non-ASCII characters. The changes include enhancements to the message search query parser, specifically improving the regex patterns for label, file description, and file title filters. These improvements support both quoted and unquoted values and enhance tag handling, thereby enabling multi-language support. The changes are documented in the
.changeset/popular-cameras-guess.mdfile and implemented in theapps/meteor/server/lib/parseMessageSearchQuery.tsfile. The source branch for this fix isfix/search-file-desc-non-ascii, and it targets thedevelopbranch.