Skip to content

Conversation

@gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented May 5, 2025

Proposed changes (including videos or screenshots)

Issue(s)

CORE-1134

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented May 5, 2025

⚠️ No Changeset found

Latest commit: fcb93b8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented May 5, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35928/

Built to branch gh-pages at 2025-05-06 19:15 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented May 5, 2025

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.23%. Comparing base (5f1eaca) to head (fcb93b8).
Report is 3 commits behind head on release-7.6.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-7.6.0   #35928      +/-   ##
=================================================
+ Coverage          61.19%   61.23%   +0.03%     
=================================================
  Files               3155     3155              
  Lines              74537    74644     +107     
  Branches           16666    16680      +14     
=================================================
+ Hits               45613    45706      +93     
- Misses             25825    25837      +12     
- Partials            3099     3101       +2     
Flag Coverage Δ
e2e 58.08% <93.33%> (+0.08%) ⬆️
unit 74.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@scuciatto scuciatto added this to the 7.6.0 milestone May 6, 2025
@gabriellsh gabriellsh marked this pull request as ready for review May 6, 2025 12:25
@gabriellsh gabriellsh requested a review from a team as a code owner May 6, 2025 12:25
@gabriellsh gabriellsh added the stat: QA assured Means it has been tested and approved by a company insider label May 6, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 6, 2025
@kodiakhq kodiakhq bot merged commit 29264b8 into release-7.6.0 May 6, 2025
41 of 42 checks passed
@kodiakhq kodiakhq bot deleted the fix/adminSettingsReactivity branch May 6, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants