Skip to content

Conversation

@gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented May 2, 2025

Proposed changes (including videos or screenshots)

Issue(s)

CORE-1135

Steps to test or reproduce

Further comments


This pull request addresses an issue in the Rocket.Chat repository where API endpoint query parameter validation was not functioning correctly for nested properties. The changes are made in the apps/meteor/app/api/server/router.ts file. The update involves modifying the router class to handle query parameters by parsing them, rather than accessing them directly from the request. This adjustment aims to improve the validation process for nested query parameters. The source branch for this fix is fix/routerQuery, and it is targeted to be merged into the develop branch.

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented May 2, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented May 2, 2025

⚠️ No Changeset found

Latest commit: 6e75203

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kody-ai
Copy link

kody-ai bot commented May 2, 2025

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Security
Code Style
Kody Rules
Refactoring
Error Handling
Maintainability
Potential Issues
Documentation And Comments
Performance And Optimization
Breaking Changes

Access your configuration settings here.

@codecov
Copy link

codecov bot commented May 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.30%. Comparing base (5f1eaca) to head (6e75203).
Report is 1 commits behind head on release-7.6.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-7.6.0   #35920      +/-   ##
=================================================
+ Coverage          61.19%   61.30%   +0.10%     
=================================================
  Files               3155     3164       +9     
  Lines              74537    74803     +266     
  Branches           16666    16694      +28     
=================================================
+ Hits               45613    45857     +244     
- Misses             25825    25846      +21     
- Partials            3099     3100       +1     
Flag Coverage Δ
e2e 58.10% <ø> (+0.10%) ⬆️
unit 75.11% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35920/

Built to branch gh-pages at 2025-05-06 12:37 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@kody-ai
Copy link

kody-ai bot commented May 6, 2025

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Security
Code Style
Kody Rules
Refactoring
Error Handling
Maintainability
Potential Issues
Documentation And Comments
Performance And Optimization
Breaking Changes

Access your configuration settings here.

@kody-ai
Copy link

kody-ai bot commented May 6, 2025

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Security
Code Style
Kody Rules
Refactoring
Error Handling
Maintainability
Potential Issues
Documentation And Comments
Performance And Optimization
Breaking Changes

Access your configuration settings here.

@gabriellsh gabriellsh changed the base branch from develop to release-7.6.0 May 6, 2025 14:09
@gabriellsh gabriellsh added this to the 7.6.0 milestone May 6, 2025
@gabriellsh gabriellsh changed the title fix: API endpoints query parameter validation not working for nested properties regression: API endpoints query parameter validation not working for nested properties May 6, 2025
expect(response2.headers).not.toHaveProperty('x-api-version');
});

it('should parse nested query params into object for GET requests', async () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@gabriellsh gabriellsh marked this pull request as ready for review May 6, 2025 14:24
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label May 6, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 6, 2025
@ggazzo ggazzo merged commit a14b259 into release-7.6.0 May 6, 2025
52 of 54 checks passed
@ggazzo ggazzo deleted the fix/routerQuery branch May 6, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants