-
Notifications
You must be signed in to change notification settings - Fork 13k
regression: API endpoints query parameter validation not working for nested properties #35920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.6.0 #35920 +/- ##
=================================================
+ Coverage 61.19% 61.30% +0.10%
=================================================
Files 3155 3164 +9
Lines 74537 74803 +266
Branches 16666 16694 +28
=================================================
+ Hits 45613 45857 +244
- Misses 25825 25846 +21
- Partials 3099 3100 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
f49a0d5 to
6e75203
Compare
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
| expect(response2.headers).not.toHaveProperty('x-api-version'); | ||
| }); | ||
|
|
||
| it('should parse nested query params into object for GET requests', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

Proposed changes (including videos or screenshots)
Issue(s)
CORE-1135
Steps to test or reproduce
Further comments
This pull request addresses an issue in the Rocket.Chat repository where API endpoint query parameter validation was not functioning correctly for nested properties. The changes are made in the
apps/meteor/app/api/server/router.tsfile. The update involves modifying the router class to handle query parameters by parsing them, rather than accessing them directly from the request. This adjustment aims to improve the validation process for nested query parameters. The source branch for this fix isfix/routerQuery, and it is targeted to be merged into thedevelopbranch.