regression: jump to message #35918

ggazzo · 2025-05-02T02:49:53Z

Proposed changes (including videos or screenshots)

Introduced here: #35818

Issue(s)

Steps to test or reproduce

Further comments

This pull request introduces several enhancements and refactorings to improve message navigation and scrolling behavior in the Rocket.Chat application. The key changes include:

New Hook for Message Navigation: A new hook, useJumpToMessageImperative, is introduced to provide an imperative method for scrolling to a specific message element, addressing complexities with custom scrollbars. This hook utilizes useRef, useCallback, and useMergedRefs for efficient reference management.
Refactoring of Existing Hooks:
- The useLoadSurroundingMessages hook is refactored to fetch the message ID from URL search parameters instead of receiving it as a prop. It now includes a jumpToRef to track the jump target element, preventing redundant operations.
- The useRestoreScrollPosition hook is updated to accept a room ID directly and uses a useCallback ref pattern for improved scroll restoration behavior.
Integration in Room Components:
- The RoomBody and RoomBodyV2 components are updated to integrate the new hooks for enhanced message list navigation. They also refactor ref handling by consolidating multiple references using useMergedRefs.
- The RoomBody component now correctly passes room._id to useRestoreScrollPosition, likely fixing previous issues.
Improved Message Fetching Logic: The useGetMore hook is refactored to centralize the logic for fetching more messages into a throttled function, checkPositionAndGetMore, which is triggered by scroll events and a new ResizeObserver. This change improves the separation of concerns, although a significant change in the condition for loading future messages requires clarification.

These changes aim to enhance the maintainability and functionality of message navigation and scrolling within the Rocket.Chat application.

dionisio-bot · 2025-05-02T02:49:56Z

Looks like this PR is not ready to merge, because of the following issues:

This PR is targeting the wrong base branch. It should target 7.6.0, but it targets 7.7.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

changeset-bot · 2025-05-02T02:49:56Z

⚠️ No Changeset found

Latest commit: e9ce201

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

kody-ai · 2025-05-02T02:49:58Z

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

apps/meteor/client/views/room/MessageList/hooks/useJumpToMessage.ts

apps/meteor/client/views/room/body/hooks/useRestoreScrollPosition.ts

apps/meteor/client/views/room/MessageList/hooks/useJumpToMessage.ts

apps/meteor/client/views/room/MessageList/hooks/useLoadSurroundingMessages.ts

apps/meteor/client/views/room/body/hooks/useGetMore.ts

github-actions · 2025-05-02T02:55:58Z

PR Preview Action v1.6.1
🚀 View preview at https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35918/
Built to branch `gh-pages` at 2025-05-02 19:35 UTC. Preview will be ready when the GitHub Pages deployment is complete.

codecov · 2025-05-02T14:20:07Z

Codecov Report

Attention: Patch coverage is 80.00000% with 20 lines in your changes missing coverage. Please review.

Project coverage is 59.86%. Comparing base (26461ca) to head (a00d29b).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #35918      +/-   ##
===========================================
- Coverage    61.26%   59.86%   -1.40%     
===========================================
  Files         3164     2880     -284     
  Lines        74757    70607    -4150     
  Branches     16689    15692     -997     
===========================================
- Hits         45801    42271    -3530     
+ Misses       25850    25547     -303     
+ Partials      3106     2789     -317

Flag	Coverage Δ
e2e	`54.43% <80.00%> (-3.59%)`	⬇️
unit	`75.11% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

kody-ai · 2025-05-02T17:34:40Z

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

kody-ai · 2025-05-02T20:23:12Z

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

kody-ai · 2025-05-02T21:12:01Z

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

kody-ai · 2025-05-02T22:10:49Z

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

apps/meteor/app/api/server/api.ts

apps/meteor/client/lib/utils/legacyJumpToMessage.ts

kody-ai · 2025-05-02T22:19:11Z

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

kody-ai · 2025-05-02T22:54:58Z

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

apps/meteor/client/views/room/body/hooks/useGetMore.spec.tsx

kody-ai · 2025-05-02T23:36:43Z

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

kody-ai · 2025-05-03T00:01:30Z

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

kody-ai · 2025-05-03T00:22:15Z

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

apps/meteor/client/views/room/contextualBar/Threads/hooks/useLegacyThreadMessages.ts

kody-ai · 2025-05-03T02:45:54Z

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

kody-ai · 2025-05-05T13:08:48Z

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

apps/meteor/app/ui-utils/client/lib/RoomHistoryManager.ts

kody-ai · 2025-05-05T19:20:56Z

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

dougfabris

I'm not happy with the path we're moving here, mixing refactor and fixes. But as we discussed, all the changes are necessary to make the regression work properly

ggazzo · 2025-05-05T19:46:02Z

I'm not happy with the path we're moving here, mixing refactor and fixes. But as we discussed, all the changes are necessary to make the regression work properly

I know but as for regression it's precisely because these parts of the refactor were left out, there was no other way to solve this.

kody-ai bot reviewed May 2, 2025

View reviewed changes

apps/meteor/client/views/room/MessageList/hooks/useJumpToMessage.ts Show resolved Hide resolved

kody-ai bot reviewed May 2, 2025

View reviewed changes

apps/meteor/client/views/room/body/hooks/useRestoreScrollPosition.ts Outdated Show resolved Hide resolved

kody-ai bot reviewed May 2, 2025

View reviewed changes

apps/meteor/client/views/room/body/hooks/useRestoreScrollPosition.ts Outdated Show resolved Hide resolved

kody-ai bot reviewed May 2, 2025

View reviewed changes

apps/meteor/client/views/room/body/hooks/useRestoreScrollPosition.ts Outdated Show resolved Hide resolved

kody-ai bot reviewed May 2, 2025

View reviewed changes

apps/meteor/client/views/room/MessageList/hooks/useJumpToMessage.ts Show resolved Hide resolved

kody-ai bot reviewed May 2, 2025

View reviewed changes

apps/meteor/client/views/room/MessageList/hooks/useLoadSurroundingMessages.ts Show resolved Hide resolved

kody-ai bot reviewed May 2, 2025

View reviewed changes

apps/meteor/client/views/room/body/hooks/useGetMore.ts Outdated Show resolved Hide resolved

ggazzo force-pushed the regression/jump-to branch 2 times, most recently from dad4c3b to dde27ab Compare May 2, 2025 14:13

ggazzo added this to the 7.6.0 milestone May 2, 2025

ggazzo force-pushed the regression/jump-to branch from 3769087 to 07a5e28 Compare May 2, 2025 19:29

ggazzo force-pushed the regression/jump-to branch from 99d35d8 to 5c24e91 Compare May 2, 2025 21:12

kody-ai bot reviewed May 2, 2025

View reviewed changes

apps/meteor/app/api/server/api.ts Outdated Show resolved Hide resolved

kody-ai bot reviewed May 2, 2025

View reviewed changes

apps/meteor/client/lib/utils/legacyJumpToMessage.ts Show resolved Hide resolved

ggazzo force-pushed the regression/jump-to branch from a795a80 to 618bbf4 Compare May 2, 2025 22:18

kody-ai bot reviewed May 2, 2025

View reviewed changes

apps/meteor/client/views/room/body/hooks/useGetMore.spec.tsx Show resolved Hide resolved

kody-ai bot reviewed May 3, 2025

View reviewed changes

apps/meteor/client/views/room/contextualBar/Threads/hooks/useLegacyThreadMessages.ts Show resolved Hide resolved

wip

c181236

ggazzo force-pushed the regression/jump-to branch from d88547f to c181236 Compare May 3, 2025 03:49

ggazzo added 2 commits May 5, 2025 10:07

fix: delete room state after logout

575f16b

just make sure we dont do anything if the element is detached

e9ce201

ggazzo marked this pull request as ready for review May 5, 2025 14:48

ggazzo requested a review from a team as a code owner May 5, 2025 14:48

dougfabris requested changes May 5, 2025

View reviewed changes

apps/meteor/app/ui-utils/client/lib/RoomHistoryManager.ts Outdated Show resolved Hide resolved

review

a00d29b

dougfabris approved these changes May 5, 2025

View reviewed changes

ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label May 5, 2025

dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 5, 2025

ggazzo merged commit da5e3de into develop May 5, 2025
39 of 42 checks passed

ggazzo deleted the regression/jump-to branch May 5, 2025 20:01

ggazzo added a commit that referenced this pull request May 5, 2025

regression: jump to message (#35918)

e7472b7

regression: jump to message #35918

regression: jump to message #35918

Uh oh!

Conversation

ggazzo commented May 2, 2025 • edited by dougfabris Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Uh oh!

dionisio-bot bot commented May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

kody-ai bot commented May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Completed! 🔥

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Built to branch gh-pages at 2025-05-02 19:35 UTC. Preview will be ready when the GitHub Pages deployment is complete.

Uh oh!

codecov bot commented May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

kody-ai bot commented May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Kody Review Complete

Uh oh!

kody-ai bot commented May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Kody Review Complete

Uh oh!

kody-ai bot commented May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Kody Review Complete

Uh oh!

kody-ai bot commented May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Completed! 🔥

Uh oh!

Uh oh!

Uh oh!

kody-ai bot commented May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Kody Review Complete

Uh oh!

kody-ai bot commented May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Completed! 🔥

Uh oh!

Uh oh!

kody-ai bot commented May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Kody Review Complete

Uh oh!

kody-ai bot commented May 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Kody Review Complete

Uh oh!

kody-ai bot commented May 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Completed! 🔥

Uh oh!

Uh oh!

kody-ai bot commented May 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Kody Review Complete

ggazzo commented May 2, 2025 •

edited by dougfabris

Loading

dionisio-bot bot commented May 2, 2025 •

edited

Loading

changeset-bot bot commented May 2, 2025 •

edited

Loading

kody-ai bot commented May 2, 2025 •

edited

Loading

github-actions bot commented May 2, 2025 •

edited

Loading

Built to branch `gh-pages` at 2025-05-02 19:35 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

codecov bot commented May 2, 2025 •

edited

Loading

kody-ai bot commented May 2, 2025 •

edited

Loading

kody-ai bot commented May 2, 2025 •

edited

Loading

kody-ai bot commented May 2, 2025 •

edited

Loading

kody-ai bot commented May 2, 2025 •

edited

Loading

kody-ai bot commented May 2, 2025 •

edited

Loading

kody-ai bot commented May 2, 2025 •

edited

Loading

kody-ai bot commented May 2, 2025 •

edited

Loading

kody-ai bot commented May 3, 2025 •

edited

Loading

kody-ai bot commented May 3, 2025 •

edited

Loading

kody-ai bot commented May 3, 2025 •

edited

Loading

kody-ai bot commented May 5, 2025 •

edited

Loading

kody-ai bot commented May 5, 2025 •

edited

Loading

dougfabris left a comment •

edited

Loading

ggazzo commented May 5, 2025 •

edited

Loading