Skip to content

Conversation

@gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Apr 29, 2025

Proposed changes (including videos or screenshots)

Issue(s)

CORE-1107

Steps to test or reproduce

Further comments


This pull request addresses a regression issue in the Rocket.Chat repository by ensuring that the audit.settings endpoint is properly secured behind the license module. The changes introduce a new API endpoint GET /v1/audit.settings which allows retrieval of audit logs related to setting changes. This endpoint supports filtering by date range, setting ID, and actor, and includes pagination and sorting capabilities. Additionally, the imports have been updated to include the necessary models and validation helpers. The source branch for this fix is fix/auditSettingsModule, and it targets the develop branch.

@gabriellsh gabriellsh requested a review from a team as a code owner April 29, 2025 19:09
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Apr 29, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Apr 29, 2025

⚠️ No Changeset found

Latest commit: a55049e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kody-ai
Copy link

kody-ai bot commented Apr 29, 2025

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Security
Code Style
Kody Rules
Refactoring
Error Handling
Maintainability
Potential Issues
Documentation And Comments
Performance And Optimization
Breaking Changes

Access your configuration settings here.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 29, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35906/

Built to branch gh-pages at 2025-04-30 15:04 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.55%. Comparing base (05c57be) to head (a55049e).
Report is 6 commits behind head on release-7.6.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-7.6.0   #35906      +/-   ##
=================================================
- Coverage          61.19%   60.55%   -0.64%     
=================================================
  Files               3154     3002     -152     
  Lines              74560    71372    -3188     
  Branches           16669    16415     -254     
=================================================
- Hits               45625    43222    -2403     
+ Misses             25830    25178     -652     
+ Partials            3105     2972     -133     
Flag Coverage Δ
e2e 56.67% <ø> (-1.33%) ⬇️
e2e-api 35.93% <ø> (-5.21%) ⬇️
unit 74.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gabriellsh gabriellsh added this to the 7.6.0 milestone Apr 29, 2025
@gabriellsh gabriellsh changed the base branch from develop to release-7.6.0 April 29, 2025 19:26
@gabriellsh gabriellsh requested review from a team as code owners April 29, 2025 19:26
@gabriellsh gabriellsh force-pushed the fix/auditSettingsModule branch from 1d70a08 to 4346967 Compare April 29, 2025 19:29
@d-gubert d-gubert removed the request for review from a team April 29, 2025 22:05
@MarcosSpessatto MarcosSpessatto removed request for a team April 30, 2025 10:51
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Apr 30, 2025
@ggazzo ggazzo merged commit 25b3fe1 into release-7.6.0 Apr 30, 2025
44 of 48 checks passed
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 30, 2025
@ggazzo ggazzo deleted the fix/auditSettingsModule branch April 30, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants