-
Notifications
You must be signed in to change notification settings - Fork 13k
regression: audit.settings endpoint not behind license module
#35906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.6.0 #35906 +/- ##
=================================================
- Coverage 61.19% 60.55% -0.64%
=================================================
Files 3154 3002 -152
Lines 74560 71372 -3188
Branches 16669 16415 -254
=================================================
- Hits 45625 43222 -2403
+ Misses 25830 25178 -652
+ Partials 3105 2972 -133
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
1d70a08 to
4346967
Compare
Proposed changes (including videos or screenshots)
Issue(s)
CORE-1107
Steps to test or reproduce
Further comments
This pull request addresses a regression issue in the Rocket.Chat repository by ensuring that the
audit.settingsendpoint is properly secured behind the license module. The changes introduce a new API endpointGET /v1/audit.settingswhich allows retrieval of audit logs related to setting changes. This endpoint supports filtering by date range, setting ID, and actor, and includes pagination and sorting capabilities. Additionally, the imports have been updated to include the necessary models and validation helpers. The source branch for this fix isfix/auditSettingsModule, and it targets thedevelopbranch.