Skip to content

Conversation

@ggazzo
Copy link
Member

@ggazzo ggazzo commented Apr 29, 2025

https://rocketchat.atlassian.net/browse/ARCH-1584
https://rocketchat.atlassian.net/browse/FLAKY-1196
https://rocketchat.atlassian.net/browse/FLAKY-1156

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Apr 29, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Apr 29, 2025

⚠️ No Changeset found

Latest commit: b3bdb63

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ggazzo ggazzo added this to the 7.7.0 milestone Apr 29, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 29, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35891/

Built to branch gh-pages at 2025-04-29 14:06 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.18%. Comparing base (348e8ba) to head (b3bdb63).
Report is 8 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35891      +/-   ##
===========================================
+ Coverage    61.17%   61.18%   +0.01%     
===========================================
  Files         3161     3162       +1     
  Lines        74702    74717      +15     
  Branches     16678    16681       +3     
===========================================
+ Hits         45700    45719      +19     
+ Misses       25901    25896       -5     
- Partials      3101     3102       +1     
Flag Coverage Δ
e2e 57.85% <ø> (+0.02%) ⬆️
unit 75.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ggazzo ggazzo marked this pull request as ready for review April 29, 2025 03:50
@ggazzo ggazzo requested a review from a team as a code owner April 29, 2025 03:50
@ggazzo ggazzo force-pushed the test/flaky-navigation-preview branch from 8dab666 to d7a9981 Compare April 29, 2025 19:51
@ggazzo ggazzo force-pushed the test/flaky-navigation-preview branch from d7a9981 to c199c78 Compare April 29, 2025 19:53
@ggazzo ggazzo marked this pull request as draft April 29, 2025 21:52
@ggazzo ggazzo marked this pull request as ready for review April 30, 2025 01:42
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Apr 30, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 30, 2025
@ggazzo ggazzo merged commit f5a05f3 into develop Apr 30, 2025
50 checks passed
@ggazzo ggazzo deleted the test/flaky-navigation-preview branch April 30, 2025 02:03
@juliajforesti juliajforesti removed the stat: ready to merge PR tested and approved waiting for merge label Apr 30, 2025
ggazzo added a commit that referenced this pull request Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants