Skip to content

Conversation

@gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Apr 28, 2025

Proposed changes (including videos or screenshots)

Issue(s)

CORE-1103

Steps to test or reproduce

Further comments


Description

This pull request focuses on refactoring the import path of the useSafeRefCallback hook within the Rocket.Chat project. The changes involve moving the hook from a local implementation to a standardized package import within the ui-client package. This refactoring effort aims to enhance code organization, maintainability, and consistency across the project.

Key Changes

  1. Refactoring Import Paths:

    • Updated the import path for useSafeRefCallback in several files to use the ui-client package instead of local imports. This change affects the following files:
      • useJumpToMessage.ts
      • useListIsAtBottom.ts
      • useIsVisible.ts
      • MessageBox.tsx
  2. Package Updates:

    • Added a new export for the useSafeRefCallback hook in the packages/ui-client/src/hooks/index.ts file.
    • Introduced a new index file for exporting the useSafeRefCallback hook in packages/ui-client/src/hooks/useSafeRefCallback/index.ts.

These changes are part of a broader effort to improve the project's dependency management and ensure a more standardized implementation of hooks across the codebase.

@gabriellsh gabriellsh requested a review from a team as a code owner April 28, 2025 21:24
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Apr 28, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Apr 28, 2025

⚠️ No Changeset found

Latest commit: 4fd7a78

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kody-ai
Copy link

kody-ai bot commented Apr 28, 2025

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Security
Code Style
Kody Rules
Refactoring
Error Handling
Maintainability
Potential Issues
Documentation And Comments
Performance And Optimization
Breaking Changes

Access your configuration settings here.

@gabriellsh gabriellsh added this to the 7.7.0 milestone Apr 28, 2025
@gabriellsh gabriellsh added the stat: QA assured Means it has been tested and approved by a company insider label Apr 28, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 28, 2025
@github-actions
Copy link
Contributor

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35890/

Built to branch gh-pages at 2025-04-28 21:34 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Apr 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.19%. Comparing base (8e8880f) to head (4fd7a78).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35890   +/-   ##
========================================
  Coverage    61.19%   61.19%           
========================================
  Files         3157     3157           
  Lines        74689    74690    +1     
  Branches     16676    16676           
========================================
+ Hits         45704    45708    +4     
+ Misses       25886    25882    -4     
- Partials      3099     3100    +1     
Flag Coverage Δ
e2e 57.87% <ø> (-0.01%) ⬇️
unit 75.10% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ggazzo ggazzo merged commit f54160b into develop Apr 28, 2025
51 of 53 checks passed
@ggazzo ggazzo deleted the chore/moveSafeRef branch April 28, 2025 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants