-
Notifications
You must be signed in to change notification settings - Fork 13.1k
chore(ui-client): Move useSafeRefCallback to package #35890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35890 +/- ##
========================================
Coverage 61.19% 61.19%
========================================
Files 3157 3157
Lines 74689 74690 +1
Branches 16676 16676
========================================
+ Hits 45704 45708 +4
+ Misses 25886 25882 -4
- Partials 3099 3100 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
Issue(s)
CORE-1103
Steps to test or reproduce
Further comments
Description
This pull request focuses on refactoring the import path of the
useSafeRefCallbackhook within the Rocket.Chat project. The changes involve moving the hook from a local implementation to a standardized package import within theui-clientpackage. This refactoring effort aims to enhance code organization, maintainability, and consistency across the project.Key Changes
Refactoring Import Paths:
useSafeRefCallbackin several files to use theui-clientpackage instead of local imports. This change affects the following files:useJumpToMessage.tsuseListIsAtBottom.tsuseIsVisible.tsMessageBox.tsxPackage Updates:
useSafeRefCallbackhook in thepackages/ui-client/src/hooks/index.tsfile.useSafeRefCallbackhook inpackages/ui-client/src/hooks/useSafeRefCallback/index.ts.These changes are part of a broader effort to improve the project's dependency management and ensure a more standardized implementation of hooks across the codebase.