fix: registration pages not compliant with a11y contrast ratio #35885
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 35125b0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #35885 +/- ##
===========================================
- Coverage 61.13% 60.35% -0.79%
===========================================
Files 3013 2906 -107
Lines 71592 70034 -1558
Branches 16397 16013 -384
===========================================
- Hits 43769 42268 -1501
- Misses 24854 24905 +51
+ Partials 2969 2861 -108
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
aleksandernsilva
left a comment
aleksandernsilva
left a comment
There was a problem hiding this comment.
Registration, forgot password and create an account pages are looking good.
I noticed that pages for legal notice, privacy police and terms of service are still using the mix of dark and light theme. Should we adjust them as well?
|
I echo the concerns from @aleksandernsilva but I think it's out of the scope of this PR a little bit. |
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
juliajforesti
force-pushed
the
fix/register-page-a11y
branch
from
118ea6d to
3de5f71
Compare
aleksandernsilva
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
dionisio-bot
bot
removed
the
stat: ready to merge
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
juliajforesti
added
the
stat: ready to merge
ARCH-1583
Proposed changes (including videos or screenshots)
Colors on registration page were not a11y compliant because some tokens were missing and it was using the wrong theme.
PaletteStyleTagto LoginPage and follow browser theme configuration@rocket.chat/layoutwith the fix for the correct tokens on Login formIssue(s)
Steps to test or reproduce
Further comments
This pull request addresses accessibility issues related to color contrast on the registration pages of the Rocket.Chat application. It introduces a changeset file that documents patch-level updates for the '@rocket.chat/web-ui-registration' and '@rocket.chat/meteor' packages, specifically targeting the resolution of these contrast issues and the application of browser theme configurations. Additionally, the PR enhances the login/registration page by adding dark mode support. This is achieved through the implementation of the
useDarkModehook and thePaletteStyleTagcomponent from the fuselage library, allowing the UI to adapt to the user's dark mode preference.