-
Notifications
You must be signed in to change notification settings - Fork 13k
fix: Contact's custom fields are now properly sent to api #35879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: ba295ad The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
apps/meteor/client/views/omnichannel/contactInfo/ContactInfo/ReviewContactModal.tsx
Show resolved
Hide resolved
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-7.6.0 #35879 +/- ##
=================================================
+ Coverage 57.14% 61.19% +4.04%
=================================================
Files 2445 3154 +709
Lines 63915 74560 +10645
Branches 14126 16669 +2543
=================================================
+ Hits 36525 45624 +9099
- Misses 25011 25831 +820
- Partials 2379 3105 +726
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
apps/meteor/client/views/omnichannel/contactInfo/ContactInfo/ReviewContactModal.tsx
Outdated
Show resolved
Hide resolved
0b62fde to
9fb0602
Compare
9fb0602 to
eb4422c
Compare
Proposed changes (including videos or screenshots)
This PR fixes a small bug that caused the API to return an error during contact's custom field conflict resolution, the issue was caused by a payload being incorrectly built and sent to the API.
Issue(s)
CTZ-97
Steps to test or reproduce
Further comments
Pull Request Description
This pull request addresses a bug in the Rocket.Chat repository, specifically in the
ReviewContactModalcomponent of the Omnichannel contact information view. The issue was related to the improper handling of contact's custom fields when sending data to the API. The changes ensure that custom fields are now correctly nested under acustomFieldsobject in the payload. This fix is implemented in theReviewContactModal.tsxfile. The source branch for this fix isbugfix/CTZ-97, and it is targeted to be merged into thedevelopbranch.