-
Notifications
You must be signed in to change notification settings - Fork 13.1k
regression: revert "regression: fix security logs timestamp discrepancy (#35865)" #35870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35870 +/- ##
===========================================
+ Coverage 61.14% 61.20% +0.06%
===========================================
Files 3009 3007 -2
Lines 71554 71472 -82
Branches 16378 16343 -35
===========================================
- Hits 43751 43748 -3
+ Misses 24836 24757 -79
Partials 2967 2967
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
This reverts commit 9d04feb.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
This pull request reverts the changes made in a previous pull request (#35865) that addressed a timestamp discrepancy in the SecurityLogsTable component. The current change modifies the timestamp format back to a date string format in the
apps/meteor/client/views/audit/components/SecurityLogsTable.tsxfile.