Skip to content

Conversation

@KevLehman
Copy link
Member

@KevLehman KevLehman commented Apr 21, 2025

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/CTZ-99

Steps to test or reproduce

Further comments

Changing the queue to run every 3 seconds should make the waits more predictable. Tried with 2 and 4 seconds and 3 was a sweet spot.

Problem with test is that for some slowliness, the server was taking a bit more than 5s to assign the chat, which made the server request the room just before it was assigned.

(Note: not that i like playing with timers & waits... but since waiting queue is based on time we have to sadly wait to test it works...)

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Apr 21, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Apr 21, 2025

⚠️ No Changeset found

Latest commit: d80a01e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Apr 21, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35848/

Built to branch gh-pages at 2025-04-21 18:40 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Apr 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.17%. Comparing base (996f5b9) to head (d80a01e).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35848   +/-   ##
========================================
  Coverage    61.17%   61.17%           
========================================
  Files         3005     3005           
  Lines        71387    71387           
  Branches     16342    16342           
========================================
  Hits         43673    43673           
+ Misses       24748    24747    -1     
- Partials      2966     2967    +1     
Flag Coverage Δ
e2e 57.88% <ø> (ø)
unit 75.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KevLehman KevLehman added the stat: QA assured Means it has been tested and approved by a company insider label Apr 21, 2025
@KevLehman KevLehman changed the title test: flaky api test test: Chat limits flaky test Apr 21, 2025
@KevLehman KevLehman added this to the 7.6.0 milestone Apr 21, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 21, 2025
@KevLehman KevLehman marked this pull request as ready for review April 21, 2025 19:49
@KevLehman KevLehman requested a review from a team as a code owner April 21, 2025 19:49
@kodiakhq kodiakhq bot merged commit 8ba005e into develop Apr 22, 2025
53 checks passed
@kodiakhq kodiakhq bot deleted the test/api-flaky branch April 22, 2025 13:21
lucas-a-pelegrino pushed a commit that referenced this pull request Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants