-
Notifications
You must be signed in to change notification settings - Fork 13.1k
test: Chat limits flaky test
#35848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Chat limits flaky test
#35848
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35848 +/- ##
========================================
Coverage 61.17% 61.17%
========================================
Files 3005 3005
Lines 71387 71387
Branches 16342 16342
========================================
Hits 43673 43673
+ Misses 24748 24747 -1
- Partials 2966 2967 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
Issue(s)
https://rocketchat.atlassian.net/browse/CTZ-99
Steps to test or reproduce
Further comments
Changing the queue to run every 3 seconds should make the waits more predictable. Tried with 2 and 4 seconds and 3 was a sweet spot.
Problem with test is that for some slowliness, the server was taking a bit more than 5s to assign the chat, which made the server request the room just before it was assigned.
(Note: not that i like playing with timers & waits... but since waiting queue is based on time we have to sadly wait to test it works...)