Skip to content

Conversation

@MarcosSpessatto
Copy link
Contributor

@MarcosSpessatto MarcosSpessatto commented Apr 17, 2025

Introduced by #35078

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

CORE-1096


This pull request aims to address a regression by reintroducing lazy loading for enterprise endpoints in the Rocket.Chat repository. Specifically, it updates the apps/meteor/ee/server/api/index.ts file by adding new imports for the engagementDashboard and audit modules. The changes are being merged from the regression/ee-endpoints branch into the develop branch.

@MarcosSpessatto MarcosSpessatto added this to the 7.6.0 milestone Apr 17, 2025
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Apr 17, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Apr 17, 2025

⚠️ No Changeset found

Latest commit: ab5d43a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kody-ai
Copy link

kody-ai bot commented Apr 17, 2025

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Security
Code Style
Kody Rules
Refactoring
Error Handling
Maintainability
Potential Issues
Documentation And Comments
Performance And Optimization
Breaking Changes

Access your configuration settings here.

@github-actions
Copy link
Contributor

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35838/

Built to branch gh-pages at 2025-04-17 19:04 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Apr 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.10%. Comparing base (e9f1d6d) to head (ab5d43a).
Report is 19 commits behind head on release-7.6.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-7.6.0   #35838      +/-   ##
=================================================
- Coverage          61.17%   61.10%   -0.07%     
=================================================
  Files               2971     2973       +2     
  Lines              70839    70907      +68     
  Branches           16185    16215      +30     
=================================================
- Hits               43333    43330       -3     
- Misses             24556    24629      +73     
+ Partials            2950     2948       -2     
Flag Coverage Δ
e2e 57.69% <ø> (+<0.01%) ⬆️
e2e-api 35.60% <ø> (-0.26%) ⬇️
unit 75.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MarcosSpessatto MarcosSpessatto marked this pull request as ready for review April 22, 2025 17:04
tassoevan
tassoevan previously approved these changes Apr 23, 2025
@MarcosSpessatto MarcosSpessatto changed the base branch from develop to release-7.6.0 April 24, 2025 13:11
@MarcosSpessatto MarcosSpessatto dismissed tassoevan’s stale review April 24, 2025 13:11

The base branch was changed.

@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Apr 25, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 25, 2025
@kodiakhq kodiakhq bot merged commit 527801b into release-7.6.0 Apr 25, 2025
57 checks passed
@kodiakhq kodiakhq bot deleted the regression/ee-endpoints branch April 25, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants