Skip to content

Conversation

@pierre-lehnen-rc
Copy link
Contributor

@pierre-lehnen-rc pierre-lehnen-rc commented Apr 17, 2025

Proposed changes (including videos or screenshots)

Issue(s)

CORE-1088

Steps to test or reproduce

Further comments


This pull request addresses an issue in the Rocket.Chat repository where VoIP calls were unable to gather Ice Servers. The changes are made in the fix/voip/ice-gathering-timeout branch and are intended to be merged into the develop branch. Key updates include:

  1. VoIP Settings: New settings for VoIP Team Collaboration have been introduced in apps/meteor/ee/server/settings/voip.ts. These settings include enable queries that conditionally activate based on the 'VoIP_TeamCollab_Enabled' setting.

  2. VoIP User Configuration: An iceGatheringTimeout property with a default value of 5000 has been added to the VoIPUserConfiguration interface in packages/core-typings/src/voip/VoIPUserConfiguration.ts.

  3. VoIP Client Enhancements: The useVoipClient hook in packages/ui-voip/src/hooks/useVoipClient.tsx has been updated to include the iceGatheringTimeout and now uses useIceServers instead of useWebRtcServers to improve VoIP client configuration.

  4. VoIP Client Initialization: The packages/ui-voip/src/lib/VoipClient.ts file now supports iceGatheringTimeout configuration during VoipClient initialization, enhancing its flexibility.

These changes collectively aim to resolve the issue with Ice Server gathering in VoIP calls and improve the overall configuration and functionality of the VoIP client.

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Apr 17, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Apr 17, 2025

🦋 Changeset detected

Latest commit: 6c6c3b4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@rocket.chat/core-typings Patch
@rocket.chat/ui-voip Patch
@rocket.chat/i18n Patch
@rocket.chat/meteor Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/mock-providers Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pierre-lehnen-rc pierre-lehnen-rc marked this pull request as ready for review April 17, 2025 00:51
@pierre-lehnen-rc pierre-lehnen-rc requested a review from a team as a code owner April 17, 2025 00:51
@kody-ai
Copy link

kody-ai bot commented Apr 17, 2025

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Security
Code Style
Kody Rules
Refactoring
Error Handling
Maintainability
Potential Issues
Documentation And Comments
Performance And Optimization
Breaking Changes

Access your configuration settings here.

@pierre-lehnen-rc pierre-lehnen-rc added this to the 7.6.0 milestone Apr 17, 2025
@codecov
Copy link

codecov bot commented Apr 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.16%. Comparing base (6401f29) to head (6c6c3b4).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35832      +/-   ##
===========================================
- Coverage    61.17%   61.16%   -0.01%     
===========================================
  Files         2971     2971              
  Lines        70838    70838              
  Branches     16184    16184              
===========================================
- Hits         43335    43328       -7     
- Misses       24554    24559       +5     
- Partials      2949     2951       +2     
Flag Coverage Δ
e2e 57.67% <ø> (-0.02%) ⬇️
unit 75.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 17, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35832/

Built to branch gh-pages at 2025-04-18 00:49 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@pierre-lehnen-rc pierre-lehnen-rc added the stat: QA assured Means it has been tested and approved by a company insider label Apr 17, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 17, 2025
@kody-ai
Copy link

kody-ai bot commented Apr 18, 2025

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Security
Code Style
Kody Rules
Refactoring
Error Handling
Maintainability
Potential Issues
Documentation And Comments
Performance And Optimization
Breaking Changes

Access your configuration settings here.

@kodiakhq kodiakhq bot merged commit bbd0b0d into develop Apr 18, 2025
48 checks passed
@kodiakhq kodiakhq bot deleted the fix/voip/ice-gathering-timeout branch April 18, 2025 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants