-
Notifications
You must be signed in to change notification settings - Fork 13k
fix: VoIP calls not gathering Ice Servers #35832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 6c6c3b4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35832 +/- ##
===========================================
- Coverage 61.17% 61.16% -0.01%
===========================================
Files 2971 2971
Lines 70838 70838
Branches 16184 16184
===========================================
- Hits 43335 43328 -7
- Misses 24554 24559 +5
- Partials 2949 2951 +2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
Proposed changes (including videos or screenshots)
Issue(s)
CORE-1088
Steps to test or reproduce
Further comments
This pull request addresses an issue in the Rocket.Chat repository where VoIP calls were unable to gather Ice Servers. The changes are made in the
fix/voip/ice-gathering-timeoutbranch and are intended to be merged into thedevelopbranch. Key updates include:VoIP Settings: New settings for VoIP Team Collaboration have been introduced in
apps/meteor/ee/server/settings/voip.ts. These settings include enable queries that conditionally activate based on the 'VoIP_TeamCollab_Enabled' setting.VoIP User Configuration: An
iceGatheringTimeoutproperty with a default value of 5000 has been added to theVoIPUserConfigurationinterface inpackages/core-typings/src/voip/VoIPUserConfiguration.ts.VoIP Client Enhancements: The
useVoipClienthook inpackages/ui-voip/src/hooks/useVoipClient.tsxhas been updated to include theiceGatheringTimeoutand now usesuseIceServersinstead ofuseWebRtcServersto improve VoIP client configuration.VoIP Client Initialization: The
packages/ui-voip/src/lib/VoipClient.tsfile now supportsiceGatheringTimeoutconfiguration during VoipClient initialization, enhancing its flexibility.These changes collectively aim to resolve the issue with Ice Server gathering in VoIP calls and improve the overall configuration and functionality of the VoIP client.