Skip to content

Conversation

@juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Apr 16, 2025

ARCH-1548

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments


@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Apr 16, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.7.0, but it targets 7.6.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Apr 16, 2025

⚠️ No Changeset found

Latest commit: 82b3f1d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kody-ai
Copy link

kody-ai bot commented Apr 16, 2025

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Security
Code Style
Kody Rules
Refactoring
Error Handling
Maintainability
Potential Issues
Documentation And Comments
Performance And Optimization
Breaking Changes

Access your configuration settings here.

@codecov
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.16%. Comparing base (8ba005e) to head (82b3f1d).
Report is 25 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35827      +/-   ##
===========================================
- Coverage    61.17%   61.16%   -0.01%     
===========================================
  Files         3005     3005              
  Lines        71387    71387              
  Branches     16342    16342              
===========================================
- Hits         43669    43663       -6     
- Misses       24750    24755       +5     
- Partials      2968     2969       +1     
Flag Coverage Δ
e2e 57.85% <100.00%> (-0.02%) ⬇️
unit 75.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@juliajforesti juliajforesti marked this pull request as ready for review April 17, 2025 15:38
@juliajforesti juliajforesti requested a review from a team as a code owner April 17, 2025 15:38
@juliajforesti juliajforesti changed the title refactor: remove Meteor from useRoomInfoEndpoint refactor: remove meteor from useRoomInfoEndpoint Apr 17, 2025
@juliajforesti juliajforesti modified the milestones: 7.6.0, 7.7.0 Apr 17, 2025
@github-actions
Copy link
Contributor

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35827/

Built to branch gh-pages at 2025-04-22 17:31 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@aleksandernsilva aleksandernsilva added the stat: QA assured Means it has been tested and approved by a company insider label Apr 28, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 28, 2025
@ggazzo ggazzo merged commit f9a7f18 into develop Apr 28, 2025
50 checks passed
@ggazzo ggazzo deleted the refactor/useRoomInfoEndpoint branch April 28, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants