fix: OutlookList not rendering properly #35816
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 6be3d64 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35816 +/- ##
========================================
Coverage 61.16% 61.16%
========================================
Files 2971 2971
Lines 70839 70839
Branches 16185 16185
========================================
+ Hits 43326 43331 +5
+ Misses 24563 24559 -4
+ Partials 2950 2949 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
![kody-ai[bot]](https://avatars.githubusercontent.com/in/413034?s=60&v=4){kind=small}
apps/meteor/client/views/outlookCalendar/OutlookEventsList/OutlookEventsList.tsx
Show resolved
Hide resolved
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
MartinSchoeler
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
Proposed changes (including videos or screenshots)
If the user tries to authenticate but do not save the credentials, the UI has a wrong verification that prevents to render the items properly. So this aims to remove it and made the checks in a correct way.
For future improvements we can refactor this component and isolate the logic from the visual in order to guarantee the visual rendering properly with snapshots tests
Issue(s)
Steps to test or reproduce
Further comments
CORE-1076
This pull request addresses an issue in the Rocket.Chat repository where the OutlookEventsList component was not rendering properly. The changes are made in the
OutlookEventsList.tsxfile within theapps/meteor/client/views/outlookCalendar/OutlookEventsListdirectory. The update involves refactoring the component by removing theContextualbarSkeletonand simplifying the conditional rendering logic. Additionally, aThrobberis introduced to handle loading states, improving the display of calendar events and error states. The source branch for this fix isfix/outlookList-render, and it targets thedevelopbranch.