-
Notifications
You must be signed in to change notification settings - Fork 13k
fix: Owner change modal not showing content as expected #35815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 15e495f The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #35815 +/- ##
===========================================
+ Coverage 64.69% 64.79% +0.10%
===========================================
Files 3244 3096 -148
Lines 95392 92232 -3160
Branches 17861 17563 -298
===========================================
- Hits 61710 59763 -1947
+ Misses 30788 29718 -1070
+ Partials 2894 2751 -143
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
dougfabris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
This pull request addresses an issue in the RocketChat/Rocket.Chat repository where the Owner change modal was not displaying content as expected. The changes are made in the
ConfirmOwnerChangeModal.tsxfile. The component has been refactored to utilize theTranscomponent fromreact-i18nextfor translations and theuseEffectEventhook for managing side effects. This update replaces the previous implementation that used theuseTranslationhook andRawTextcomponent. The source branch for this fix isdelete-user-owner, and it is targeted to be merged into thedevelopbranch.CORE-1093