Skip to content

Conversation

@yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented Apr 15, 2025

Proposed changes (including videos or screenshots)

image

Issue(s)

Steps to test or reproduce

Further comments


This pull request addresses an issue in the RocketChat/Rocket.Chat repository where the Owner change modal was not displaying content as expected. The changes are made in the ConfirmOwnerChangeModal.tsx file. The component has been refactored to utilize the Trans component from react-i18next for translations and the useEffectEvent hook for managing side effects. This update replaces the previous implementation that used the useTranslation hook and RawText component. The source branch for this fix is delete-user-owner, and it is targeted to be merged into the develop branch.

CORE-1093

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Apr 15, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Apr 15, 2025

🦋 Changeset detected

Latest commit: 15e495f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@rocket.chat/i18n Patch
@rocket.chat/meteor Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-voip Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/model-typings Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kody-ai
Copy link

kody-ai bot commented Apr 15, 2025

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Security
Code Style
Kody Rules
Refactoring
Error Handling
Maintainability
Potential Issues
Documentation And Comments
Performance And Optimization
Breaking Changes

Access your configuration settings here.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 15, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35815/

Built to branch gh-pages at 2025-05-13 14:51 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

Attention: Patch coverage is 14.54545% with 47 lines in your changes missing coverage. Please review.

Project coverage is 64.79%. Comparing base (eb3d03f) to head (15e495f).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35815      +/-   ##
===========================================
+ Coverage    64.69%   64.79%   +0.10%     
===========================================
  Files         3244     3096     -148     
  Lines        95392    92232    -3160     
  Branches     17861    17563     -298     
===========================================
- Hits         61710    59763    -1947     
+ Misses       30788    29718    -1070     
+ Partials      2894     2751     -143     
Flag Coverage Δ
e2e 58.36% <37.50%> (+0.09%) ⬆️
unit 71.88% <3.63%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yash-rajpal yash-rajpal marked this pull request as ready for review April 22, 2025 15:01
@yash-rajpal yash-rajpal requested a review from a team as a code owner April 22, 2025 15:01
@yash-rajpal yash-rajpal added the stat: QA assured Means it has been tested and approved by a company insider label Apr 22, 2025
@yash-rajpal yash-rajpal added this to the 7.7.0 milestone Apr 22, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 22, 2025
jessicaschelly
jessicaschelly previously approved these changes Apr 22, 2025
@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Apr 23, 2025
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Apr 23, 2025

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yash-rajpal yash-rajpal added the stat: ready to merge PR tested and approved waiting for merge label May 13, 2025
@kodiakhq kodiakhq bot merged commit fdb3b57 into develop May 13, 2025
48 checks passed
@kodiakhq kodiakhq bot deleted the delete-user-owner branch May 13, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants