fix: LDAP Sync stops processing users if any entry can't be mapped to a Rocket.Chat user #35810

pierre-lehnen-rc · 2025-04-15T16:58:49Z

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Pull Request Description

This pull request addresses an issue in the Rocket.Chat repository where the LDAP Background Sync process would halt if any LDAP user entry could not be mapped to a Rocket.Chat user. The fix ensures that the sync process continues even if some entries cannot be mapped, improving the robustness of the LDAP synchronization feature. The changes are made in the fix/ldap-error-on-entry-callback branch and are intended to be merged into the develop branch.

… a Rocket.Chat user

dionisio-bot · 2025-04-15T16:58:52Z

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

changeset-bot · 2025-04-15T16:58:52Z

🦋 Changeset detected

Latest commit: d9a96b2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/api-client	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/freeswitch	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/models	Patch
@rocket.chat/network-broker	Patch
@rocket.chat/mock-providers	Patch
@rocket.chat/ui-avatar	Patch
@rocket.chat/ui-client	Patch
@rocket.chat/ui-video-conf	Patch
@rocket.chat/ui-voip	Patch
@rocket.chat/web-ui-registration	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

kody-ai · 2025-04-15T16:59:29Z

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

.changeset/yellow-comics-cheer.md

github-actions · 2025-04-15T17:13:08Z

PR Preview Action v1.6.1
🚀 View preview at https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35810/
Built to branch `gh-pages` at 2025-04-17 23:50 UTC. Preview will be ready when the GitHub Pages deployment is complete.

codecov · 2025-04-15T17:13:42Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.18%. Comparing base (a7104a5) to head (d9a96b2).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #35810      +/-   ##
===========================================
+ Coverage    61.16%   61.18%   +0.01%     
===========================================
  Files         2971     2971              
  Lines        70839    70835       -4     
  Branches     16185    16184       -1     
===========================================
+ Hits         43329    43338       +9     
+ Misses       24560    24548      -12     
+ Partials      2950     2949       -1

Flag	Coverage Δ
e2e	`57.70% <ø> (+0.02%)`	⬆️
unit	`75.61% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

kody-ai · 2025-04-16T16:50:59Z

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

kody-ai · 2025-04-16T23:45:33Z

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

kody-ai · 2025-04-17T04:33:07Z

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

kody-ai · 2025-04-17T05:12:00Z

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

kody-ai · 2025-04-17T23:38:45Z

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

fix: LDAP Sync stops processing users if any entry can't be mapped to…

2697e09

… a Rocket.Chat user

pierre-lehnen-rc marked this pull request as ready for review April 15, 2025 16:59

pierre-lehnen-rc requested a review from a team as a code owner April 15, 2025 16:59

kody-ai bot reviewed Apr 15, 2025

View reviewed changes

.changeset/yellow-comics-cheer.md Show resolved Hide resolved

abhinavkrin approved these changes Apr 16, 2025

View reviewed changes

pierre-lehnen-rc added the stat: QA assured Means it has been tested and approved by a company insider label Apr 16, 2025

pierre-lehnen-rc added this to the 7.6.0 milestone Apr 16, 2025

dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 16, 2025

Merge branch 'develop' into fix/ldap-error-on-entry-callback

c4adfb7

Merge branch 'develop' into fix/ldap-error-on-entry-callback

9d51241

Merge branch 'develop' into fix/ldap-error-on-entry-callback

1c60de5

Merge branch 'develop' into fix/ldap-error-on-entry-callback

1461e53

Merge branch 'develop' into fix/ldap-error-on-entry-callback

d9a96b2

kodiakhq bot merged commit 6401f29 into develop Apr 18, 2025
48 checks passed

kodiakhq bot deleted the fix/ldap-error-on-entry-callback branch April 18, 2025 00:36

rocketchat-github-ci mentioned this pull request Apr 20, 2025

Release 7.6.0 #35843

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: LDAP Sync stops processing users if any entry can't be mapped to a Rocket.Chat user #35810

fix: LDAP Sync stops processing users if any entry can't be mapped to a Rocket.Chat user #35810

Uh oh!

pierre-lehnen-rc commented Apr 15, 2025 •

edited by kody-ai bot

Loading

Uh oh!

dionisio-bot bot commented Apr 15, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Apr 15, 2025 •

edited

Loading

Uh oh!

kody-ai bot commented Apr 15, 2025 •

edited

Loading

Uh oh!

Uh oh!

github-actions bot commented Apr 15, 2025 •

edited

Loading

Built to branch `gh-pages` at 2025-04-17 23:50 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Uh oh!

codecov bot commented Apr 15, 2025 •

edited

Loading

Uh oh!

kody-ai bot commented Apr 16, 2025 •

edited

Loading

Uh oh!

kody-ai bot commented Apr 16, 2025 •

edited

Loading

Uh oh!

kody-ai bot commented Apr 17, 2025 •

edited

Loading

Uh oh!

kody-ai bot commented Apr 17, 2025 •

edited

Loading

Uh oh!

kody-ai bot commented Apr 17, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix: LDAP Sync stops processing users if any entry can't be mapped to a Rocket.Chat user #35810

fix: LDAP Sync stops processing users if any entry can't be mapped to a Rocket.Chat user #35810

Uh oh!

Conversation

pierre-lehnen-rc commented Apr 15, 2025 • edited by kody-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Pull Request Description

Uh oh!

dionisio-bot bot commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

kody-ai bot commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Completed! 🔥

Uh oh!

Uh oh!

github-actions bot commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Built to branch gh-pages at 2025-04-17 23:50 UTC. Preview will be ready when the GitHub Pages deployment is complete.

Uh oh!

codecov bot commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

kody-ai bot commented Apr 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Completed! 🔥

Uh oh!

kody-ai bot commented Apr 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Completed! 🔥

Uh oh!

kody-ai bot commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Completed! 🔥

Uh oh!

kody-ai bot commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Completed! 🔥

Uh oh!

kody-ai bot commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Completed! 🔥

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pierre-lehnen-rc commented Apr 15, 2025 •

edited by kody-ai bot

Loading

dionisio-bot bot commented Apr 15, 2025 •

edited

Loading

changeset-bot bot commented Apr 15, 2025 •

edited

Loading

kody-ai bot commented Apr 15, 2025 •

edited

Loading

github-actions bot commented Apr 15, 2025 •

edited

Loading

Built to branch `gh-pages` at 2025-04-17 23:50 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

codecov bot commented Apr 15, 2025 •

edited

Loading

kody-ai bot commented Apr 16, 2025 •

edited

Loading

kody-ai bot commented Apr 16, 2025 •

edited

Loading

kody-ai bot commented Apr 17, 2025 •

edited

Loading

kody-ai bot commented Apr 17, 2025 •

edited

Loading

kody-ai bot commented Apr 17, 2025 •

edited

Loading