fix: incoming webhook "Post As" field not updating userId #35795

abhinavkrin · 2025-04-14T11:19:32Z

Proposed changes (including videos or screenshots)

Fixes the issue where updating the "Post As" field in the incoming webhook integration settings only changed the username and not the userId, resulting in messages being sent as the original user.

The integration now properly updates both username and userId to ensure the message sender reflects the selected user.

Issue(s)

Steps to test or reproduce

Go to Administration → Integrations → Incoming Webhooks.
Edit an existing webhook and change the "Post As" field to another valid user.
Save and trigger the webhook.
Confirm that the message is posted as the new selected user.

Further comments

CORE-1083

This pull request addresses an issue in the Rocket.Chat repository where the "Post As" field for incoming webhooks was not updating the userId correctly. The changes ensure that both username and userId are properly synchronized when the 'Post As' field is updated. The update includes a refactor of the channel validation logic into a new function validateChannels, improving code modularity and readability. Additionally, the handling of the associated user during integration updates is refined to modify username and userId only when explicitly provided. The findOneAndUpdate method is configured to return the updated document, which is a best practice. The changes also include adding the returnDocument option in the outgoing integration update method to ensure the updated document is returned after the update operation.

dionisio-bot · 2025-04-14T11:19:36Z

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

changeset-bot · 2025-04-14T11:19:36Z

🦋 Changeset detected

Latest commit: b6d51cb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/api-client	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/freeswitch	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/models	Patch
@rocket.chat/network-broker	Patch
@rocket.chat/mock-providers	Patch
@rocket.chat/ui-avatar	Patch
@rocket.chat/ui-client	Patch
@rocket.chat/ui-video-conf	Patch
@rocket.chat/ui-voip	Patch
@rocket.chat/web-ui-registration	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov · 2025-04-14T11:24:18Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.98%. Comparing base (ae18eef) to head (b6d51cb).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #35795      +/-   ##
===========================================
- Coverage    60.99%   60.98%   -0.01%     
===========================================
  Files         2956     2956              
  Lines        70539    70539              
  Branches     16174    16174              
===========================================
- Hits         43022    43015       -7     
- Misses       24567    24573       +6     
- Partials      2950     2951       +1

Flag	Coverage Δ
e2e	`57.69% <ø> (-0.02%)`	⬇️
unit	`75.30% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2025-04-14T11:24:30Z

PR Preview Action v1.6.1
🚀 View preview at https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35795/
Built to branch `gh-pages` at 2025-04-16 22:26 UTC. Preview will be ready when the GitHub Pages deployment is complete.

kody-ai · 2025-04-15T09:50:38Z

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

kody-ai · 2025-04-15T18:08:05Z

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

Signed-off-by: Abhinav Kumar <[email protected]>

…-userid

kody-ai · 2025-04-16T19:41:11Z

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

…-userid

kody-ai · 2025-04-16T20:10:18Z

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

…-userid

kody-ai · 2025-04-16T21:01:29Z

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

…-userid

kody-ai · 2025-04-16T21:20:30Z

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

…-userid

kody-ai · 2025-04-16T21:53:17Z

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

abhinavkrin · 2025-05-16T15:03:53Z

/backport 7.5.2

abhinavkrin · 2025-05-19T17:42:52Z

/backport 7.5.2

ggazzo · 2025-05-19T18:05:33Z

/backport 7.5.2

abhinavkrin requested a review from a team as a code owner April 14, 2025 11:19

abhinavkrin added this to the 7.6.0 milestone Apr 14, 2025

abhinavkrin added 2 commits April 16, 2025 00:52

fix: incoming webhook "Post As" field not updating userId

1f2f9d0

Signed-off-by: Abhinav Kumar <[email protected]>

added changeset

ad84068

Signed-off-by: Abhinav Kumar <[email protected]>

abhinavkrin force-pushed the fix/incoming-webhook-post-as-not-updating-userid branch from 7ad512f to ad84068 Compare April 15, 2025 19:22

modified tests

9fbc00b

Signed-off-by: Abhinav Kumar <[email protected]>

abhinavkrin marked this pull request as draft April 16, 2025 06:31

abhinavkrin marked this pull request as ready for review April 16, 2025 06:31

MarcosSpessatto approved these changes Apr 16, 2025

View reviewed changes

abhinavkrin added the stat: QA assured Means it has been tested and approved by a company insider label Apr 16, 2025

dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 16, 2025

Merge branch 'develop' into fix/incoming-webhook-post-as-not-updating…

2a30e86

…-userid

Merge branch 'develop' into fix/incoming-webhook-post-as-not-updating…

1da8f53

…-userid

Merge branch 'develop' into fix/incoming-webhook-post-as-not-updating…

5660ed4

…-userid

Merge branch 'develop' into fix/incoming-webhook-post-as-not-updating…

c9ed583

…-userid

Merge branch 'develop' into fix/incoming-webhook-post-as-not-updating…

b6d51cb

…-userid

kodiakhq bot merged commit dc6cf3e into develop Apr 17, 2025
48 checks passed

kodiakhq bot deleted the fix/incoming-webhook-post-as-not-updating-userid branch April 17, 2025 01:36

rocketchat-github-ci mentioned this pull request Apr 20, 2025

Release 7.6.0 #35843

Merged

RocketChat deleted a comment from dionisio-bot bot May 14, 2025

fix: incoming webhook "Post As" field not updating userId #35795

fix: incoming webhook "Post As" field not updating userId #35795

Uh oh!

Conversation

abhinavkrin commented Apr 14, 2025 • edited by kody-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Uh oh!

dionisio-bot bot commented Apr 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Apr 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

codecov bot commented Apr 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Apr 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Built to branch gh-pages at 2025-04-16 22:26 UTC. Preview will be ready when the GitHub Pages deployment is complete.

Uh oh!

kody-ai bot commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Kody Review Complete

Uh oh!

kody-ai bot commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Completed! 🔥

Uh oh!

kody-ai bot commented Apr 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Completed! 🔥

Uh oh!

kody-ai bot commented Apr 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Kody Review Complete

Uh oh!

kody-ai bot commented Apr 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Completed! 🔥

Uh oh!

kody-ai bot commented Apr 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Kody Review Complete

Uh oh!

kody-ai bot commented Apr 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Completed! 🔥

Uh oh!

Uh oh!

abhinavkrin commented May 16, 2025

Uh oh!

abhinavkrin commented May 19, 2025

Uh oh!

ggazzo commented May 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

abhinavkrin commented Apr 14, 2025 •

edited by kody-ai bot

Loading

dionisio-bot bot commented Apr 14, 2025 •

edited

Loading

changeset-bot bot commented Apr 14, 2025 •

edited

Loading

codecov bot commented Apr 14, 2025 •

edited

Loading

github-actions bot commented Apr 14, 2025 •

edited

Loading

Built to branch `gh-pages` at 2025-04-16 22:26 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

kody-ai bot commented Apr 15, 2025 •

edited

Loading

kody-ai bot commented Apr 15, 2025 •

edited

Loading

kody-ai bot commented Apr 16, 2025 •

edited

Loading

kody-ai bot commented Apr 16, 2025 •

edited

Loading

kody-ai bot commented Apr 16, 2025 •

edited

Loading

kody-ai bot commented Apr 16, 2025 •

edited

Loading

kody-ai bot commented Apr 16, 2025 •

edited

Loading