regression: incoming integration not working with new hono router

[MarcosSpessatto]

Introduced by #35078

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

---

Description

This pull request addresses a regression issue where incoming integrations were not functioning correctly with the new hono router in the Rocket.Chat application. The changes are made in the following files:

1. apps/meteor/app/api/server/router.ts:

   • Modifications are made to the body parameter parsing logic within the Router class. The focus is on handling override parameters and cases where the body is empty.

2. apps/meteor/app/integrations/server/api/api.js:

   • Updates are implemented for webhook request handling, emphasizing asynchronous body parsing using modern JavaScript features.
   • URL construction is improved using the standard URL API and the x-forwarded-proto header.
   • Refinements are made to the header and body data passed to integration scripts.
   • Middleware is adjusted to handle application/x-www-form-urlencoded payloads that contain JSON.

These changes aim to enhance the functionality and reliability of incoming integrations with the new router setup.

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: 376f7a5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.01%. Comparing base (f22a6db) to head (376f7a5).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #35772   +/-   ##
========================================
  Coverage    61.01%   61.01%           
========================================
  Files         3099     3099           
  Lines        73248    73248           
  Branches     16398    16398           
========================================
+ Hits         44690    44693    +3     
  Misses       25534    25534           
+ Partials      3024     3021    -3     

Flag	Coverage Δ
e2e	57.65% <ø> (+<0.01%)	⬆️
unit	75.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

PR Preview Action v1.6.1
🚀 View preview at https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35772/
Built to branch gh-pages at 2025-04-15 11:45 UTC. Preview will be ready when the GitHub Pages deployment is complete.

[kody-ai]

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration

Interacting with Kody

• Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

• Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

​

[kody-ai]

const MAX_PAYLOAD_SIZE = 10 * 1024 * 1024; // 10MB limit
const contentLength = parseInt(this.request.headers.get('content-length') || '0', 10);
if (contentLength > MAX_PAYLOAD_SIZE) {
  throw new Error('Payload too large');
}
const buffers = [];
let totalSize = 0;
for await (const chunk of this.request.body) {
  totalSize += chunk.length;
  if (totalSize > MAX_PAYLOAD_SIZE) {
    throw new Error('Payload too large');
  }
  buffers.push(chunk);
}
const content_raw = Buffer.concat(buffers).toString('utf8');

The code buffers the entire request body into memory without size limits, which can lead to memory exhaustion for large payloads.

This issue appears in multiple locations:

• apps/meteor/app/integrations/server/api/api.js: Lines 91-95
• apps/meteor/app/integrations/server/api/api.js: Lines 328-328
  Please implement size limits for request body processing to prevent memory exhaustion.

_{Talk to Kody by mentioning @kody}

_{Was this suggestion helpful? React with 👍 or 👎 to help Kody learn from this interaction.}

​

​