fix: voip calls not ringing after temporary disconnection #35765

pierre-lehnen-rc · 2025-04-10T16:58:17Z

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

This pull request addresses an issue with VoIP calls not ringing after a temporary disconnection in the Rocket.Chat application. The changes include:

Documentation: A changeset file has been added to document patch updates for '@rocket.chat/ui-voip' and '@rocket.chat/meteor', specifically targeting the VoIP call delivery issue post-disconnection.
UI Updates:
- In useVoipItemsSection.tsx files located in both NavBarSettingsToolbar/UserMenu/hooks and sidebar/header/hooks, handling for the VoIP reconnection state has been added, along with updates to related UI components.
- A new localization key Reconnecting with its English translation has been added to the en.i18n.json file.
State Management Enhancements:
- A new state property 'isReconnecting' has been introduced to the VoipState type in useVoipState.tsx, enhancing the management of VoIP connection states.
- In VoipClient.ts, state management and logic for handling VoIP client reconnections have been introduced. This includes a reconnecting flag, associated methods, and improved client state reporting. Additionally, new handlers onUserAgentConnected and onUserAgentDisconnected have been implemented to manage the connection lifecycle more robustly, including registration and unregistration attempts.

These changes aim to improve the reliability and user experience of VoIP calls within the application by ensuring calls ring even after temporary disconnections.

dionisio-bot · 2025-04-10T16:58:21Z

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

changeset-bot · 2025-04-10T16:58:21Z

🦋 Changeset detected

Latest commit: b710219

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages

Name	Type
@rocket.chat/ui-voip	Patch
@rocket.chat/meteor	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/api-client	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/freeswitch	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/models	Patch
@rocket.chat/network-broker	Patch
@rocket.chat/mock-providers	Patch
@rocket.chat/ui-avatar	Patch
@rocket.chat/ui-client	Patch
@rocket.chat/ui-video-conf	Patch
@rocket.chat/web-ui-registration	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2025-04-10T17:03:19Z

PR Preview Action v1.6.1
🚀 View preview at https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35765/
Built to branch `gh-pages` at 2025-04-15 12:23 UTC. Preview will be ready when the GitHub Pages deployment is complete.

codecov · 2025-04-10T17:04:17Z

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 61.00%. Comparing base (d165f0c) to head (b710219).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #35765      +/-   ##
===========================================
- Coverage    61.01%   61.00%   -0.01%     
===========================================
  Files         3099     3099              
  Lines        73248    73252       +4     
  Branches     16398    16400       +2     
===========================================
- Hits         44694    44690       -4     
- Misses       25532    25539       +7     
- Partials      3022     3023       +1

Flag	Coverage Δ
e2e	`57.64% <25.00%> (-0.02%)`	⬇️
unit	`75.49% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

kody-ai · 2025-04-15T12:15:44Z

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

apps/meteor/client/NavBarV2/NavBarSettingsToolbar/UserMenu/hooks/useVoipItemsSection.tsx

apps/meteor/client/sidebar/header/hooks/useVoipItemsSection.tsx

kody-ai · 2025-04-15T14:13:13Z

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

kody-ai · 2025-04-15T15:45:31Z

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

fix: voip calls not ringing after temporary disconnection

ed6992d

pierre-lehnen-rc added 2 commits April 10, 2025 14:19

only auto register if a registration was lost before

0719cd9

show reconnecting status on usermenu

27d1307

pierre-lehnen-rc marked this pull request as ready for review April 10, 2025 20:44

pierre-lehnen-rc requested a review from a team as a code owner April 10, 2025 20:44

pierre-lehnen-rc mentioned this pull request Apr 10, 2025

feat: improve voip error handling #35776

Merged

MarcosSpessatto added this to the 7.6.0 milestone Apr 11, 2025

MarcosSpessatto approved these changes Apr 11, 2025

View reviewed changes

pierre-lehnen-rc added the stat: QA assured Means it has been tested and approved by a company insider label Apr 11, 2025

dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 11, 2025

dougfabris approved these changes Apr 15, 2025

View reviewed changes

Merge branch 'develop' into fix/voip-reconnection

f3d8dab

kody-ai bot reviewed Apr 15, 2025

View reviewed changes

apps/meteor/client/NavBarV2/NavBarSettingsToolbar/UserMenu/hooks/useVoipItemsSection.tsx Show resolved Hide resolved

kody-ai bot reviewed Apr 15, 2025

View reviewed changes

apps/meteor/client/sidebar/header/hooks/useVoipItemsSection.tsx Show resolved Hide resolved

tassoevan approved these changes Apr 15, 2025

View reviewed changes

Merge branch 'develop' into fix/voip-reconnection

ddfe96c

Merge branch 'develop' into fix/voip-reconnection

b710219

kodiakhq bot merged commit ec78941 into develop Apr 15, 2025
48 checks passed

kodiakhq bot deleted the fix/voip-reconnection branch April 15, 2025 17:46

rocketchat-github-ci mentioned this pull request Apr 20, 2025

Release 7.6.0 #35843

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: voip calls not ringing after temporary disconnection #35765

fix: voip calls not ringing after temporary disconnection #35765

Uh oh!

pierre-lehnen-rc commented Apr 10, 2025 •

edited by kody-ai bot

Loading

Uh oh!

dionisio-bot bot commented Apr 10, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Apr 10, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Apr 10, 2025 •

edited

Loading

Built to branch `gh-pages` at 2025-04-15 12:23 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Uh oh!

codecov bot commented Apr 10, 2025 •

edited

Loading

Uh oh!

kody-ai bot commented Apr 15, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

kody-ai bot commented Apr 15, 2025 •

edited

Loading

Uh oh!

kody-ai bot commented Apr 15, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fix: voip calls not ringing after temporary disconnection #35765

fix: voip calls not ringing after temporary disconnection #35765

Uh oh!

Conversation

pierre-lehnen-rc commented Apr 10, 2025 • edited by kody-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Uh oh!

dionisio-bot bot commented Apr 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Apr 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions bot commented Apr 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Built to branch gh-pages at 2025-04-15 12:23 UTC. Preview will be ready when the GitHub Pages deployment is complete.

Uh oh!

codecov bot commented Apr 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

kody-ai bot commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Completed! 🔥

Uh oh!

Uh oh!

Uh oh!

kody-ai bot commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Kody Review Complete

Uh oh!

kody-ai bot commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Completed! 🔥

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

pierre-lehnen-rc commented Apr 10, 2025 •

edited by kody-ai bot

Loading

dionisio-bot bot commented Apr 10, 2025 •

edited

Loading

changeset-bot bot commented Apr 10, 2025 •

edited

Loading

github-actions bot commented Apr 10, 2025 •

edited

Loading

Built to branch `gh-pages` at 2025-04-15 12:23 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

codecov bot commented Apr 10, 2025 •

edited

Loading

kody-ai bot commented Apr 15, 2025 •

edited

Loading

kody-ai bot commented Apr 15, 2025 •

edited

Loading

kody-ai bot commented Apr 15, 2025 •

edited

Loading