Skip to content

Conversation

@aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Apr 8, 2025

Proposed changes (including videos or screenshots)

This PR appends uuid to the default name used by the createUnit util function in our e2e tests. This aims to prevent name collisions due to repeated names generated by faker.

Issue(s)

ARCH-1534

Steps to test or reproduce

N/A

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Apr 8, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Apr 8, 2025

⚠️ No Changeset found

Latest commit: 44e140a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35738/

Built to branch gh-pages at 2025-04-29 17:33 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.21%. Comparing base (5832dd9) to head (44e140a).
Report is 8 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35738      +/-   ##
===========================================
+ Coverage    61.15%   61.21%   +0.05%     
===========================================
  Files         3013     3011       -2     
  Lines        71589    71506      -83     
  Branches     16397    16346      -51     
===========================================
- Hits         43779    43771       -8     
+ Misses       24841    24767      -74     
+ Partials      2969     2968       -1     
Flag Coverage Δ
e2e 57.85% <ø> (-0.01%) ⬇️
unit 75.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aleksandernsilva aleksandernsilva force-pushed the test/unit-name-collision branch from ee86a88 to a702949 Compare April 24, 2025 13:09
@aleksandernsilva aleksandernsilva marked this pull request as ready for review April 25, 2025 17:59
@aleksandernsilva aleksandernsilva added the stat: QA assured Means it has been tested and approved by a company insider label Apr 25, 2025
@aleksandernsilva aleksandernsilva added this to the 7.7.0 milestone Apr 25, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 25, 2025
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Apr 29, 2025
@ggazzo ggazzo merged commit 88b64ae into develop Apr 30, 2025
49 checks passed
@ggazzo ggazzo deleted the test/unit-name-collision branch April 30, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants