Skip to content

Conversation

@Gustrb
Copy link
Contributor

@Gustrb Gustrb commented Apr 8, 2025

Proposed changes (including videos or screenshots)

Added a translation key instead of just using correcting the typo.

Issue(s)

Steps to test or reproduce

Further comments

https://rocketchat.atlassian.net/browse/CONN-595

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Apr 8, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Apr 8, 2025

🦋 Changeset detected

Latest commit: 95234d4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/i18n Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-voip Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/model-typings Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Gustrb Gustrb added this to the 7.6.0 milestone Apr 8, 2025
@Gustrb Gustrb added the stat: QA assured Means it has been tested and approved by a company insider label Apr 8, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 8, 2025
@Gustrb Gustrb changed the title fix: type on app setting save fix: typo on app setting save Apr 8, 2025
@Gustrb Gustrb marked this pull request as ready for review April 8, 2025 16:36
@Gustrb Gustrb requested a review from a team as a code owner April 8, 2025 16:36
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35733/

Built to branch gh-pages at 2025-04-08 20:43 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.64%. Comparing base (87a1589) to head (95234d4).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35733   +/-   ##
========================================
  Coverage    59.64%   59.64%           
========================================
  Files         2832     2832           
  Lines        68322    68322           
  Branches     15133    15133           
========================================
  Hits         40750    40750           
  Misses       24963    24963           
  Partials      2609     2609           
Flag Coverage Δ
unit 75.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@aleksandernsilva aleksandernsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a changeset for this change?

@Gustrb Gustrb requested a review from aleksandernsilva April 8, 2025 17:49
Co-authored-by: Aleksander Nicacio da Silva <[email protected]>
@kodiakhq kodiakhq bot merged commit be67bb7 into develop Apr 9, 2025
48 checks passed
@kodiakhq kodiakhq bot deleted the fix/typo-on-app-save branch April 9, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants