-
Notifications
You must be signed in to change notification settings - Fork 13k
fix: typo on app setting save #35733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 95234d4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35733 +/- ##
========================================
Coverage 59.64% 59.64%
========================================
Files 2832 2832
Lines 68322 68322
Branches 15133 15133
========================================
Hits 40750 40750
Misses 24963 24963
Partials 2609 2609
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
aleksandernsilva
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a changeset for this change?
Co-authored-by: Aleksander Nicacio da Silva <[email protected]>
Co-authored-by: Aleksander Nicacio da Silva <[email protected]>
Proposed changes (including videos or screenshots)
Added a translation key instead of just using correcting the typo.
Issue(s)
Steps to test or reproduce
Further comments
https://rocketchat.atlassian.net/browse/CONN-595