fix: allow to load dynamic rest endpoint #35715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 70f5639 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35715 +/- ##
========================================
Coverage 59.63% 59.63%
========================================
Files 2832 2832
Lines 68301 68301
Branches 15131 15131
========================================
Hits 40730 40730
Misses 24962 24962
Partials 2609 2609
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
MarcosSpessatto
suggested changes
Apr 8, 2025
ggazzo
force-pushed
the
fix/dynamic-enpoints
branch
from
09b2cda to
70f5639
Compare
MarcosSpessatto
approved these changes
Apr 8, 2025
ggazzo
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Member
Author
|
/patch |
Contributor
after that just run |
ggazzo
added a commit
that referenced
this pull request
Apr 8, 2025
Co-authored-by: gabriellsh <[email protected]>
Member
Author
|
/patch |
Member
Author
|
/backport 7.4.2 |
Contributor
|
Sorry, I couldn't do that backport because of conflicts. Could you please solve them? you can do so by running the following commands: after that just run |
ggazzo
added a commit
that referenced
this pull request
Apr 8, 2025
Co-authored-by: gabriellsh <[email protected]>
Member
Author
|
/backport 7.4.2 |
Contributor
|
Pull request #35731 added to Project: "Patch 7.4.2" |
Member
Author
|
/patch |
Contributor
|
Pull request #35732 added to Project: "Patch 7.5.1" |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
API Routes registered after startup weren't working, such as enterprise APIs that are only registered after a valid license is detected.
Issue(s)
SUP-757
Steps to test or reproduce
Make sure to not trigger a restart (by restarting manually or changin BE code) during this process or the results will differ.
Further comments
https://rocketchat.atlassian.net/browse/CORE-1068
[SUP-757]: https://rocketchat.atlassian.net/browse/SUP-757?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ