Skip to content

Conversation

@aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Apr 3, 2025

Proposed changes (including videos or screenshots)

This PR adds the action to dismiss the contact unknown callout. The decision will be stored (for the duration of the browser session) by contact, meaning subsequent access to rooms with the same contact won't display the callout.

Before

image

After

Screenshot 2025-04-04 at 11 14 26

Issue(s)

CTZ-32

Steps to test or reproduce

  • Access a workspace
  • Make sure it has single contact id addon
  • Access a livechat room
  • Contact unknown callout should be visible

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Apr 3, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Apr 3, 2025

🦋 Changeset detected

Latest commit: 42c2392

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/i18n Minor
@rocket.chat/mock-providers Patch
@rocket.chat/ui-contexts Major
@rocket.chat/web-ui-registration Major
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/ui-client Major
@rocket.chat/ui-voip Major
@rocket.chat/uikit-playground Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-video-conf Major
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/model-typings Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@aleksandernsilva aleksandernsilva force-pushed the feat/dismiss-contact-unknown-callout branch 2 times, most recently from 56aac0f to 63e6c82 Compare April 3, 2025 22:01
@codecov
Copy link

codecov bot commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.62%. Comparing base (ca6870a) to head (42c2392).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35703   +/-   ##
========================================
  Coverage    59.62%   59.62%           
========================================
  Files         2832     2832           
  Lines        68356    68356           
  Branches     15140    15140           
========================================
  Hits         40758    40758           
  Misses       24992    24992           
  Partials      2606     2606           
Flag Coverage Δ
unit 75.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35703/

Built to branch gh-pages at 2025-04-10 14:51 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@aleksandernsilva aleksandernsilva force-pushed the feat/dismiss-contact-unknown-callout branch from 63e6c82 to 4ccc583 Compare April 3, 2025 22:29
@aleksandernsilva aleksandernsilva marked this pull request as ready for review April 4, 2025 14:15
@aleksandernsilva aleksandernsilva requested a review from a team as a code owner April 4, 2025 14:15
@aleksandernsilva aleksandernsilva added this to the 7.6.0 milestone Apr 4, 2025
tiagoevanp
tiagoevanp previously approved these changes Apr 4, 2025
@ggazzo
Copy link
Member

ggazzo commented Apr 4, 2025

The decision will be stored by contact, meaning subsequent access to rooms with the same contact won't display the callout.

this is not exactly true right? you are not actually storing forever its only a local thing.

btw: is this never going to be removed?

@renatobecker renatobecker added the stat: QA assured Means it has been tested and approved by a company insider label Apr 8, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 8, 2025
@aleksandernsilva
Copy link
Contributor Author

@ggazzo I updated the PR description to be more precise. I also spoke with product and storing the decision for the duration of the browser session meets our needs. So, I updated the logic to use session storage instead of local storage. This ensures the information is not stored indefinitely and gives users more opportunities to change their minds if they choose to.

Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Apr 10, 2025
@aleksandernsilva aleksandernsilva added stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA assured Means it has been tested and approved by a company insider labels Apr 10, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 10, 2025
@kodiakhq kodiakhq bot merged commit 895ea3f into develop Apr 10, 2025
48 checks passed
@kodiakhq kodiakhq bot deleted the feat/dismiss-contact-unknown-callout branch April 10, 2025 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants