-
Notifications
You must be signed in to change notification settings - Fork 13k
feat: Allow to dismiss contact unknown callout #35703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 42c2392 The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
56aac0f to
63e6c82
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35703 +/- ##
========================================
Coverage 59.62% 59.62%
========================================
Files 2832 2832
Lines 68356 68356
Branches 15140 15140
========================================
Hits 40758 40758
Misses 24992 24992
Partials 2606 2606
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
63e6c82 to
4ccc583
Compare
this is not exactly true right? you are not actually storing forever its only a local thing. btw: is this never going to be removed? |
apps/meteor/client/views/room/composer/ComposerOmnichannel/ComposerOmnichannelCallout.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/room/composer/ComposerOmnichannel/ComposerOmnichannelCallout.tsx
Show resolved
Hide resolved
|
@ggazzo I updated the PR description to be more precise. I also spoke with product and storing the decision for the duration of the browser session meets our needs. So, I updated the logic to use session storage instead of local storage. This ensures the information is not stored indefinitely and gives users more opportunities to change their minds if they choose to. |
dougfabris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Proposed changes (including videos or screenshots)
This PR adds the action to dismiss the contact unknown callout. The decision will be stored (for the duration of the browser session) by contact, meaning subsequent access to rooms with the same contact won't display the callout.
Before
After
Issue(s)
CTZ-32
Steps to test or reproduce
Further comments