fix: Active toggle now reflects current active status #35698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 3f04fb7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35698 +/- ##
===========================================
+ Coverage 60.98% 61.00% +0.01%
===========================================
Files 2956 2956
Lines 70539 70539
Branches 16174 16174
===========================================
+ Hits 43017 43029 +12
+ Misses 24571 24561 -10
+ Partials 2951 2949 -2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
aleksandernsilva
requested changes
Apr 8, 2025
Contributor
aleksandernsilva
left a comment
aleksandernsilva
left a comment
There was a problem hiding this comment.
Tested and toggle is working as expected after the fix. Also tests are covering the expected behavior and failing without the fix.
Just take a look at the following:
- Test clean up
- Add a changeset to this PR
- If possible reference the PR that introduced this issue, it will help us during root cause analysis.
renatobecker
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
![kody-ai[bot]](https://avatars.githubusercontent.com/in/413034?s=60&v=4){kind=small}
apps/meteor/client/views/omnichannel/businessHours/EditBusinessHours.tsx
Show resolved
Hide resolved
aleksandernsilva
requested changes
Apr 15, 2025
Co-authored-by: Aleksander Nicacio da Silva <aleksander.silva@rocket.chat>
aleksandernsilva
approved these changes
Apr 15, 2025
dionisio-bot
bot
removed
the
stat: ready to merge
scuciatto
added
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR fixes an issue where the toggle switch for business hours didn't reflect the current status when BH was disabled, making the user unable to reactivate the BH.
Issue(s)
CTZ-34
Steps to test or reproduce
Further comments
This pull request addresses a bug in the Rocket.Chat repository by updating the
EditBusinessHours.tsxfile within theapps/meteor/client/views/omnichannel/businessHoursdirectory. The change involves replacing a logical OR (||) with a nullish coalescing operator (??) for the initialization of the 'active' property. This modification enhances type safety and ensures proper handling of falsy values, allowing the active toggle to accurately reflect the current active status. The changes are being merged from thebugfix/CTZ-34branch into thedevelopbranch.