Skip to content

Conversation

@debdutdeb
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Apr 3, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is targeting the wrong base branch. It should target 7.6.0, but it targets 7.5.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Apr 3, 2025

⚠️ No Changeset found

Latest commit: fda9123

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.62%. Comparing base (4cb4edf) to head (fda9123).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35694   +/-   ##
========================================
  Coverage    59.62%   59.62%           
========================================
  Files         2829     2829           
  Lines        68292    68292           
  Branches     15135    15135           
========================================
  Hits         40720    40720           
  Misses       24963    24963           
  Partials      2609     2609           
Flag Coverage Δ
unit 75.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35694/

Built to branch gh-pages at 2025-04-03 14:33 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@debdutdeb debdutdeb marked this pull request as ready for review April 3, 2025 16:02
@debdutdeb debdutdeb requested a review from a team as a code owner April 3, 2025 16:02
@debdutdeb debdutdeb changed the title ci: update node version in matrix step ci: fix matrix sdk native build Apr 3, 2025
@debdutdeb debdutdeb requested a review from ggazzo April 3, 2025 16:04
@ggazzo ggazzo added this to the 7.6.0 milestone Apr 3, 2025
@ggazzo ggazzo merged commit 66c2134 into develop Apr 3, 2025
14 of 15 checks passed
@ggazzo ggazzo deleted the fix-ci-matrix branch April 3, 2025 17:30
ggazzo pushed a commit that referenced this pull request Apr 3, 2025
@sampaiodiego
Copy link
Member

/backport 7.4.2

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Apr 8, 2025

Sorry, I couldn't do that backport because of conflicts. Could you please solve them?

you can do so by running the following commands:

git fetch
git checkout backport-7.4.2-35694
git cherry-pick 66c2134eaab75c6a33caadbb4c967754aecd8225
// solve the conflict
git push

after that just run /backport 7.4.2 again

sampaiodiego pushed a commit that referenced this pull request Apr 8, 2025
@sampaiodiego
Copy link
Member

/backport 7.4.2

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Apr 8, 2025

Pull request #35740 added to Project: "Patch 7.4.2"

@julio-rocketchat
Copy link
Member

/backport 7.3.6

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jun 23, 2025

Sorry, I couldn't do that backport because of conflicts. Could you please solve them?

you can do so by running the following commands:

git fetch
git checkout backport-7.3.6-35694
git cherry-pick 66c2134eaab75c6a33caadbb4c967754aecd8225
// solve the conflict
git push

after that just run /backport 7.3.6 again

@julio-rocketchat
Copy link
Member

/backport 7.3.6

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jun 23, 2025

Pull request #36279 added to Project: "Patch 7.3.6"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants