Skip to content

Conversation

@pierre-lehnen-rc
Copy link
Contributor

@pierre-lehnen-rc pierre-lehnen-rc commented Apr 2, 2025

Proposed changes (including videos or screenshots)

Issue(s)

CORE-1061

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Apr 2, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Apr 2, 2025

⚠️ No Changeset found

Latest commit: 82e7318

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pierre-lehnen-rc pierre-lehnen-rc changed the title regression: calendar-events.update endpoint not updating event's endTime regression: calendar-events.update endpoint not updating new attributes Apr 2, 2025
@pierre-lehnen-rc pierre-lehnen-rc marked this pull request as ready for review April 2, 2025 19:00
@pierre-lehnen-rc pierre-lehnen-rc requested a review from a team as a code owner April 2, 2025 19:00
@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35687/

Built to branch gh-pages at 2025-04-02 21:33 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.59%. Comparing base (c618263) to head (82e7318).
Report is 4 commits behind head on release-7.5.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-7.5.0   #35687      +/-   ##
=================================================
- Coverage          59.64%   59.59%   -0.05%     
=================================================
  Files               2832     2832              
  Lines              68934    68972      +38     
  Branches           15287    15307      +20     
=================================================
- Hits               41113    41103      -10     
- Misses             25143    25188      +45     
- Partials            2678     2681       +3     
Flag Coverage Δ
unit 75.61% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ggazzo ggazzo added this to the 7.5.0 milestone Apr 2, 2025
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Apr 2, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 2, 2025
@ggazzo ggazzo merged commit c4c37f1 into release-7.5.0 Apr 2, 2025
9 of 10 checks passed
@ggazzo ggazzo deleted the fix/calendar-events-update-endtime branch April 2, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants