Skip to content

Conversation

@gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Apr 1, 2025

Proposed changes (including videos or screenshots)

Issue(s)

CORE-1055

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Apr 1, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Apr 1, 2025

⚠️ No Changeset found

Latest commit: 6697f35

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gabriellsh gabriellsh added this to the 7.5.0 milestone Apr 1, 2025
@scuciatto scuciatto modified the milestones: 7.5.0, 7.6.0 Apr 1, 2025
@gabriellsh gabriellsh changed the title regression: Recent Emoji list lost between refreshes regression: Emoji Picker recent list and load more not working Apr 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35673/

Built to branch gh-pages at 2025-04-02 21:27 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 59.62%. Comparing base (183c43c) to head (6697f35).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35673      +/-   ##
===========================================
- Coverage    59.63%   59.62%   -0.01%     
===========================================
  Files         2829     2829              
  Lines        68284    68292       +8     
  Branches     15132    15135       +3     
===========================================
  Hits         40720    40720              
- Misses       24954    24963       +9     
+ Partials      2610     2609       -1     
Flag Coverage Δ
unit 75.61% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@ggazzo ggazzo modified the milestones: 7.6.0, 7.5.0 Apr 2, 2025
@ggazzo ggazzo requested a review from a team as a code owner April 2, 2025 21:15
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Apr 2, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 2, 2025
@ggazzo ggazzo merged commit a1ec1e3 into develop Apr 2, 2025
8 of 9 checks passed
@ggazzo ggazzo deleted the fix/recentEmoji branch April 2, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants