-
Notifications
You must be signed in to change notification settings - Fork 13k
feat: Bring back previous announcement style #35672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 73d02b5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
b96fc15 to
c766e85
Compare
ce121c6 to
4fc972a
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35672 +/- ##
===========================================
+ Coverage 59.62% 59.63% +0.01%
===========================================
Files 2830 2832 +2
Lines 68297 68299 +2
Branches 15134 15130 -4
===========================================
+ Hits 40719 40732 +13
+ Misses 24969 24958 -11
Partials 2609 2609
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
1eef6bc to
709edb0
Compare
709edb0 to
55f66d8
Compare
apps/meteor/client/views/room/RoomAnnouncement/RoomAnnouncement.tsx
Outdated
Show resolved
Hide resolved
2cb6081 to
73d02b5
Compare
Proposed changes (including videos or screenshots)
Important
This change is under feature preview
After trying a new approach in the announcement for rooms, the design team decided to bring back the previous style in the enhanced navigation feature preview
Issue(s)
Steps to test or reproduce
Enhanced Navigation Experiencefeature previewFurther comments
SIDE2-17