fix: throws errors for apps properly #35667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 066588d The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.5.0 #35667 +/- ##
==============================================
Coverage 59.64% 59.64%
==============================================
Files 2832 2832
Lines 68934 68934
Branches 15287 15287
==============================================
Hits 41113 41113
Misses 25143 25143
Partials 2678 2678
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a regression issue with error messaging in the creator methods by enhancing error handling in the ModifyCreator class and adding comprehensive tests for various error scenarios.
- Updated error handling in ModifyCreator to differentiate between known and unknown error objects.
- Added tests for getLivechatCreator, getUploadCreator, getEmailCreator, and getContactCreator to verify consistent error throwing behavior.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/apps-engine/deno-runtime/lib/accessors/tests/ModifyCreator.test.ts | Added tests to ensure proper error propagation and handling across various creator methods. |
| packages/apps-engine/deno-runtime/lib/accessors/modify/ModifyCreator.ts | Updated catch blocks in creator methods to handle Error instances and error objects with a message property. |
Comments suppressed due to low confidence (1)
packages/apps-engine/deno-runtime/lib/accessors/modify/ModifyCreator.ts:68
- [nitpick] When the error object lacks a 'message' property, directly wrapping 'err.error' may produce an uninformative default message such as '[object Object]'. Consider providing a more descriptive default error message or a fallback string.
throw new Error(err.error);
alfredodelfabro
changed the title
d-gubert
previously approved these changes
Apr 2, 2025
sampaiodiego
approved these changes
Apr 2, 2025
sampaiodiego
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
CTZ-33
Steps to test or reproduce
Further comments