Skip to content

refactor: remove CustomSounds from meteor #35666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ggazzo merged 9 commits into from
Apr 4, 2025
Merged

refactor: remove CustomSounds from meteor #35666

ggazzo merged 9 commits into from
Apr 4, 2025

Conversation

@juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Mar 31, 2025 •
edited by atlassian bot
Loading

ARCH-1519

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Mar 31, 2025 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Mar 31, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3e024d3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Mar 31, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.62%. Comparing base (dcc0f18) to head (3e024d3).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35666      +/-   ##
===========================================
- Coverage    59.62%   59.62%   -0.01%     
===========================================
  Files         2830     2830              
  Lines        68304    68297       -7     
  Branches     15135    15134       -1     
===========================================
- Hits         40724    40719       -5     
+ Misses       24971    24969       -2     
  Partials      2609     2609
Flag Coverage Δ
unit 75.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 31, 2025 •
edited
Loading

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35666/

Built to branch gh-pages at 2025-04-04 13:18 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@juliajforesti juliajforesti force-pushed the refactor/custom-sounds branch 6 times, most recently from f90cb3b to cf9aca1 Compare April 4, 2025 13:12
@juliajforesti juliajforesti force-pushed the refactor/custom-sounds branch from cf9aca1 to 3e024d3 Compare April 4, 2025 13:41
@juliajforesti juliajforesti marked this pull request as ready for review April 4, 2025 13:53
@juliajforesti juliajforesti requested a review from a team as a code owner April 4, 2025 13:53
@juliajforesti juliajforesti added this to the 7.6.0 milestone Apr 4, 2025
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Apr 4, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 4, 2025
@ggazzo ggazzo merged commit a486016 into develop Apr 4, 2025
40 of 42 checks passed
@ggazzo ggazzo deleted the refactor/custom-sounds branch April 4, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggazzo ggazzo ggazzo approved these changes

Assignees

No one assigned

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Milestone

7.6.0

Development

Successfully merging this pull request may close these issues.

3 participants

@juliajforesti @ggazzo