Skip to content

Conversation

@dougfabris
Copy link
Member

@dougfabris dougfabris commented Mar 25, 2025

Proposed changes (including videos or screenshots)

Important

This change is under feature preview

It replaces the parent room tag in room header in favor of a button to back to the parent room

parent team

image

parent room

image

Issue(s)

Steps to test or reproduce

  • Enable the Enhanced Navigation Experience feature preview
  • Create a team
  • Create a channel or discussion and enter it
  • Check the button to get back to the parent room in the header

Further comments

SIDE2-38

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Mar 25, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.6.0, but it targets 7.5.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Mar 25, 2025

🦋 Changeset detected

Latest commit: 2394d6d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@rocket.chat/ui-client Major
@rocket.chat/i18n Minor
@rocket.chat/meteor Minor
@rocket.chat/gazzodown Major
@rocket.chat/ui-voip Major
@rocket.chat/web-ui-registration Major
@rocket.chat/mock-providers Patch
@rocket.chat/ui-contexts Major
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/livechat Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-video-conf Major
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/model-typings Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dougfabris dougfabris changed the title feat: Use IconButton in favor of Tag to navigate to parent room feat: Use IconButton to navigate to parent room Mar 25, 2025
@dougfabris dougfabris added this to the 7.6.0 milestone Mar 25, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35613/

Built to branch gh-pages at 2025-04-02 22:09 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.62%. Comparing base (c51bd13) to head (2394d6d).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35613   +/-   ##
========================================
  Coverage    59.62%   59.62%           
========================================
  Files         2829     2829           
  Lines        68292    68292           
  Branches     15135    15151   +16     
========================================
  Hits         40720    40720           
  Misses       24963    24963           
  Partials      2609     2609           
Flag Coverage Δ
unit 75.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dougfabris dougfabris marked this pull request as ready for review March 27, 2025 21:08
@dougfabris dougfabris requested review from a team as code owners March 27, 2025 21:08
Copy link
Contributor

@tassoevan tassoevan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apps/meteor/tests/e2e/utils/createTargetDiscussion.ts is empty?

juliajforesti
juliajforesti previously approved these changes Apr 1, 2025
@juliajforesti juliajforesti added the stat: QA assured Means it has been tested and approved by a company insider label Apr 1, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 1, 2025
tassoevan
tassoevan previously approved these changes Apr 2, 2025
Copy link
Contributor

@tassoevan tassoevan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apps/meteor/tests/e2e/utils/createTargetDiscussion.ts is empty?

@dougfabris dougfabris removed the stat: ready to merge PR tested and approved waiting for merge label Apr 2, 2025
@dougfabris dougfabris dismissed stale reviews from tassoevan and juliajforesti via 88973a1 April 2, 2025 18:14
@dougfabris dougfabris removed the stat: QA assured Means it has been tested and approved by a company insider label Apr 2, 2025
@dougfabris dougfabris force-pushed the feat/replace-parentTag branch from 8b8acf8 to 7bf6300 Compare April 2, 2025 23:10
@dougfabris dougfabris requested a review from juliajforesti April 2, 2025 23:11
@juliajforesti juliajforesti added the stat: QA assured Means it has been tested and approved by a company insider label Apr 3, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 3, 2025
@kodiakhq kodiakhq bot merged commit f545617 into develop Apr 3, 2025
47 checks passed
@kodiakhq kodiakhq bot deleted the feat/replace-parentTag branch April 3, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants