-
Notifications
You must be signed in to change notification settings - Fork 13k
feat: Use IconButton to navigate to parent room
#35613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 2394d6d The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
IconButton in favor of Tag to navigate to parent roomIconButton to navigate to parent room
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35613 +/- ##
========================================
Coverage 59.62% 59.62%
========================================
Files 2829 2829
Lines 68292 68292
Branches 15135 15151 +16
========================================
Hits 40720 40720
Misses 24963 24963
Partials 2609 2609
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
apps/meteor/client/views/room/HeaderV2/ParentRoom/ParentRoom.tsx
Outdated
Show resolved
Hide resolved
tassoevan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apps/meteor/tests/e2e/utils/createTargetDiscussion.ts is empty?
tassoevan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apps/meteor/tests/e2e/utils/createTargetDiscussion.ts is empty?
8b8acf8 to
7bf6300
Compare
Proposed changes (including videos or screenshots)
Important
This change is under feature preview
It replaces the parent room tag in room header in favor of a button to back to the parent room
parent team
parent room
Issue(s)
Steps to test or reproduce
Enhanced Navigation Experiencefeature previewFurther comments
SIDE2-38