-
Notifications
You must be signed in to change notification settings - Fork 13k
fix: EmojiPicker unnecessary rerenders
#35605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: b4361f3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
EmojiPickerunnecessary rerendersEmojiPicker unnecessary rerenders
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #35605 +/- ##
===========================================
- Coverage 59.72% 59.69% -0.03%
===========================================
Files 2829 2829
Lines 68233 68230 -3
Branches 15125 15116 -9
===========================================
- Hits 40751 40729 -22
- Misses 24874 24894 +20
+ Partials 2608 2607 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
Every scroll or hovering of an element cause the whole list to be rebuilt from the ground up. This should no longer be the case.
Issue(s)
CORE-1043
Steps to test or reproduce
Further comments