Skip to content

Conversation

@gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Mar 24, 2025

Proposed changes (including videos or screenshots)

Every scroll or hovering of an element cause the whole list to be rebuilt from the ground up. This should no longer be the case.

Issue(s)

CORE-1043

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Mar 24, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Mar 24, 2025

🦋 Changeset detected

Latest commit: b4361f3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gabriellsh gabriellsh changed the title fix: EmojiPickerunnecessary rerenders fix: EmojiPicker unnecessary rerenders Mar 24, 2025
@gabriellsh gabriellsh marked this pull request as ready for review March 24, 2025 21:12
@gabriellsh gabriellsh requested a review from a team as a code owner March 24, 2025 21:12
@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35605/

Built to branch gh-pages at 2025-03-27 21:35 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Mar 24, 2025

Codecov Report

Attention: Patch coverage is 26.47059% with 25 lines in your changes missing coverage. Please review.

Project coverage is 59.69%. Comparing base (45e1ab3) to head (54ac15b).
Report is 6 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35605      +/-   ##
===========================================
- Coverage    59.72%   59.69%   -0.03%     
===========================================
  Files         2829     2829              
  Lines        68233    68230       -3     
  Branches     15125    15116       -9     
===========================================
- Hits         40751    40729      -22     
- Misses       24874    24894      +20     
+ Partials      2608     2607       -1     
Flag Coverage Δ
unit 75.87% <26.47%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gabriellsh gabriellsh marked this pull request as draft March 27, 2025 23:28
@scuciatto scuciatto added this to the 7.6.0 milestone Apr 1, 2025
@scuciatto scuciatto marked this pull request as ready for review April 1, 2025 14:26
@ggazzo ggazzo modified the milestones: 7.6.0, 7.5.0 Apr 1, 2025
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Apr 1, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 1, 2025
@ggazzo ggazzo merged commit c5f6734 into develop Apr 1, 2025
27 of 29 checks passed
@ggazzo ggazzo deleted the fix/emojiPickerPerf branch April 1, 2025 14:47
ggazzo pushed a commit that referenced this pull request Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants